Add new RiotID routes; Capture RiotIDGameName from MatchV5 #60
Conversation
riot/account/account.go
Outdated
| ) | ||
|
|
||
| // AccountClient provides methods for the account endpoints of the League of Legends API. | ||
| type AccountClient struct { //nolint:golint |
There was a problem hiding this comment.
@KnutZuidema in the other PR you mentioned this should be renamed to Client. However, account.Client already exists in account/client.go so that this package conforms to the same structure in the lol package.
I can change this if you want, but if another account-family endpoint(s) is added by riot at some point it may be useful to keep this structure? Up to you
There was a problem hiding this comment.
Fair point. I would assume that the endpoint hierarchy for accounts will stay flat, so let's just implement all the actions directly on the Client type. If another set of endpoints is added later, we'll have to refactor.
|
@harmonherring, not sure how it got in there, but the commit |
|
Riot also stated in this article that
endpoints are deprecated from now on, so it may be a good idea to include a comment on this. |
|
@KnutZuidema are there plans to merge this MR in the near future? |
harmonherring
force-pushed
the
capture-game-name-and-fixes
branch
from
5dd1723 to
8e2cb65
Compare
harmonherring
force-pushed
the
capture-game-name-and-fixes
branch
from
8e2cb65 to
1bce0c4
Compare
|
@KnutZuidema apologies for the delay on this 😅 I've implemented the account methods directly on Client as you asked and also rebased that odd commit out of history |
I agree, let's do this in a separate PR 😄 |
Since it seems #59 is dead I've opened this PR. It's pretty much identical besides a few minor fixes
by-riot-idendpoint path