-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(txfee): add priority transaction fee support for tendermint coins #2282
base: dev
Are you sure you want to change the base?
Conversation
CosmosGasPriority { | ||
gas_limit: u64, | ||
gas_price_option: TendermintPriorityFeeOption, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we extend existing option CosmosGas
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I did this like EthGasEip1559 option (which is also a dedicated variant to set priority tx fee for eth).
Also, if we combine mutually exclusive gas_price: f64
and gas_price_option: TendermintPriorityFeeOption
in CosmosGas, this would require extra checks in the code.
I assume this will require updates to the coins repo? How often do the priority values change? Does |
Yes we need to set "priority_gas_prices": [0.1, 0.2, 0.3] in the coin file. We could get them from cosmos registry (they maintain those params for each chain). It was supposed that GUI will call set_swap_transaction_fee_policy (low, medium, priority) before starting a swap (after asking the user which one the user prefers). |
Please ping me once this is ready for review. It's tagged with |
Continuing adding priority transaction fee requested in issue #1848, now for Tendermint.
There are three priority levels for tx fees: low, average and high, allowing to users to set higher priority for their transactions by paying more fees.
Cosmos has a registry for its chain ecosystem: https://github.com/cosmos/chain-registry which contains suggested priority tx fees for different coins.
The priority fees from the Cosmos registry should be added in the coins file (for the platform coin only) like:
To set priority level with withdraw, WithdrawFee::CosmosGasPriority variant is added.
To set priority for swaps,
set_swap_transaction_fee_policy()
implemented for TendermintCoin.