forked from jl777/SuperNET
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fs): make filter_files_by_extension
return only files
#2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onur-ozkan
reviewed
Feb 17, 2025
onur-ozkan
reviewed
Feb 17, 2025
onur-ozkan
reviewed
Feb 17, 2025
onur-ozkan
reviewed
Feb 17, 2025
onur-ozkan
reviewed
Feb 17, 2025
onur-ozkan
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
shamardy
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the find and the fix!
filter_files_by_extension
return only files
dimxy
added a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Feb 24, 2025
* dev: (24 commits) fix(eth-tpu): remove state from funding validation (KomodoPlatform#2334) improvement(rpc-server): rpc server dynamic port allocation (KomodoPlatform#2342) fix(tests): fix or ignore unstable tests (KomodoPlatform#2365) fix(fs): make `filter_files_by_extension` return only files (KomodoPlatform#2364) fix(derive_key_from_path): check length of current_key_material (KomodoPlatform#2356) chore(release): bump mm2 version to 2.4.0-beta (KomodoPlatform#2346) fix(tests): add additional testnet sepolia nodes to test code (KomodoPlatform#2358) fix(swaps): maintain legacy compatibility for negotiation messages (KomodoPlatform#2353) refactor(SwapOps): impl defaults for protocol specific swapops fns (KomodoPlatform#2354) feat(tpu-v2): provide swap protocol versioning (KomodoPlatform#2324) feat(wallet): add change mnemonic password rpc (KomodoPlatform#2317) fix(tpu-v2): fix tpu-v2 wait for payment spend and extract secret (KomodoPlatform#2261) feat(tendermint): unstaking/undelegation (KomodoPlatform#2330) fix(utxo-withdraw): get hw ctx only when `PrivKeyPolicy` is trezor (KomodoPlatform#2333) feat(event-streaming): API-driven subscription management (KomodoPlatform#2172) fix(hash-types): remove panic, enforce fixed-size arrays (KomodoPlatform#2279) fix(ARRR): store unconfirmed change output (KomodoPlatform#2276) feat(tendermint): staking/delegation (KomodoPlatform#2322) chore(deps): `timed-map` migration (KomodoPlatform#2247) fix(mem-leak): `running_swap` never shrinks (KomodoPlatform#2301) ...
dimxy
added a commit
that referenced
this pull request
Feb 26, 2025
* dev: feat(tendermint): claim delegation rewards (#2351) fix(eth-tpu): remove state from funding validation (#2334) improvement(rpc-server): rpc server dynamic port allocation (#2342) fix(tests): fix or ignore unstable tests (#2365) fix(fs): make `filter_files_by_extension` return only files (#2364)
dimxy
added a commit
that referenced
this pull request
Mar 5, 2025
* dev: feat(rpc): add is_success field to legacy MySwapStatusResponse (#2371) fix(key-derivation): use stored Argon2 parameters instead of default values (#2360) fix(tests): stabilize `tendermint_coin::test_claim_staking_rewards` (#2373) improvement(RPCs): group staking rpcs under a namespace (#2372) feat(tendermint): claim delegation rewards (#2351) fix(eth-tpu): remove state from funding validation (#2334) improvement(rpc-server): rpc server dynamic port allocation (#2342) fix(tests): fix or ignore unstable tests (#2365) fix(fs): make `filter_files_by_extension` return only files (#2364) fix(derive_key_from_path): check length of current_key_material (#2356) chore(release): bump mm2 version to 2.4.0-beta (#2346) fix(tests): add additional testnet sepolia nodes to test code (#2358) fix(swaps): maintain legacy compatibility for negotiation messages (#2353) refactor(SwapOps): impl defaults for protocol specific swapops fns (#2354) feat(tpu-v2): provide swap protocol versioning (#2324) feat(wallet): add change mnemonic password rpc (#2317)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default,
get_wallet_names
returns not only*.dat
filenames fromdb_root
as wallet names but also directories. For example, if we create al.dat
folder indb_root
, it will be included in the wallet names list, like this:The current implementation is not necessarily ideal. Maybe we should perform this check (i.e., ensuring it’s a file and not a directory) directly in
filter_files_by_extension
. But my primary goal was to avoid modifying existing file-related functions.