You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But it seems that only default verification task (i.e. koverVerify) verifies coverage report based on the top level rule and Android report verification tasks (i.e. koverVerify{VariantName}) do not use the rule.
Errors
No error is found.
Expected behavior
Verification rule for all report variants is applied to Android report variants, which are executed by koverVerify{VariantName}, as well as default report.
Following screenshot shows the result of verification task executions on the reproducer project mentioned above. Note that the verification for release variant in the capture is failed because the variant has variant-specific verification rule.
Environment
Kover Gradle Plugin version: 0.7.3
Gradle version: 8.2
Kotlin project type: confirmed with Kotlin/Android and Kotlin/Multiplatform + Android
Coverage Toolset (if customized in build script): Kover
Other context important for this bug:
OS: macOS Ventura 13.5.2
The text was updated successfully, but these errors were encountered:
Now, when creating the Android report configuration, on Check is immediately set for verification.
This is not necessary, because if not specified, only the `koverVerify` task is started when executing check, but not the tasks of verifying Android build variant.
This has a negative side effect, because the verification for the build variant is always specify, and it will override the common rules from the root of the report config `koverReport { verify { /* common rules */ } }`
Fixes#459
Now, when creating the Android report configuration, on Check is immediately set for verification.
According to the rules for Android reports, if onCheck is not specified, it is taken as false.
Now, to install onCheck, the reports.verify { block is called.
if you look at its implementation, you can see that the default value for verify config is null.
When a user writes verify { }, according to the current rules, it automatically resets all filters declared in the hierarchy above.
The problem was that the onCheck setting took place through a verify block call, which should be filled in by the user, so the filters seem to be erased.
Fixes#459
PR #502
Describe the bug
From descriptions in the docs, top level verification rule should be applied to all variants including Android build variants:
But it seems that only default verification task (i.e.
koverVerify
) verifies coverage report based on the top level rule and Android report verification tasks (i.e.koverVerify{VariantName}
) do not use the rule.Errors
No error is found.
Expected behavior
Verification rule for all report variants is applied to Android report variants, which are executed by
koverVerify{VariantName}
, as well as default report.Reproducer
I created a reproducer project: https://github.com/nashcft/repro-kover-verification
Reports
Following screenshot shows the result of verification task executions on the reproducer project mentioned above. Note that the verification for
release
variant in the capture is failed because the variant has variant-specific verification rule.Environment
The text was updated successfully, but these errors were encountered: