You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Indra seems to add dependencies to the module path in via the Gradle eclipse plugin even when a project has no module-info.java or automatic module name set. This can lead to the project failing to be compiled in eclipse due to JPMS errors.
Geyser is an example of this, which recently moved to Indra for builds but does not declare modules. I opened a PR there to temporarily mitigate this GeyserMC/Geyser#3584 but they advised I open a bug on Indra. It can also be mitigated by temporarily setting inferModulePath to false, as that ensures the check for if a library should be added to the module path returns false.
Indra seems to add dependencies to the module path in via the Gradle eclipse plugin even when a project has no module-info.java or automatic module name set. This can lead to the project failing to be compiled in eclipse due to JPMS errors.
Geyser is an example of this, which recently moved to Indra for builds but does not declare modules. I opened a PR there to temporarily mitigate this GeyserMC/Geyser#3584 but they advised I open a bug on Indra. It can also be mitigated by temporarily setting inferModulePath to false, as that ensures the check for if a library should be added to the module path returns false.
Relevant code:
https://github.com/KyoriPowered/indra/blob/main/3.x/indra-common/src/main/java/net/kyori/indra/internal/multirelease/IndraMultireleasePlugin.java#L540-L569
https://github.com/KyoriPowered/indra/blob/main/3.x/indra-common/src/main/java/net/kyori/indra/internal/ModularityDetecter.java#L53-L117
I also discussed in the Adventure Discord. See https://discord.com/channels/319355592605040642/923221456073150525/1079701892550103040.
The text was updated successfully, but these errors were encountered: