Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indra Incorrectly Sets Libraries as Modules on Eclipse in Non-Modular Project #116

Closed
Kas-tle opened this issue Mar 1, 2023 · 0 comments · Fixed by #130
Closed

Indra Incorrectly Sets Libraries as Modules on Eclipse in Non-Modular Project #116

Kas-tle opened this issue Mar 1, 2023 · 0 comments · Fixed by #130
Labels
type: bug Something isn't working
Milestone

Comments

@Kas-tle
Copy link

Kas-tle commented Mar 1, 2023

Indra seems to add dependencies to the module path in via the Gradle eclipse plugin even when a project has no module-info.java or automatic module name set. This can lead to the project failing to be compiled in eclipse due to JPMS errors.

Geyser is an example of this, which recently moved to Indra for builds but does not declare modules. I opened a PR there to temporarily mitigate this GeyserMC/Geyser#3584 but they advised I open a bug on Indra. It can also be mitigated by temporarily setting inferModulePath to false, as that ensures the check for if a library should be added to the module path returns false.

Relevant code:
https://github.com/KyoriPowered/indra/blob/main/3.x/indra-common/src/main/java/net/kyori/indra/internal/multirelease/IndraMultireleasePlugin.java#L540-L569
https://github.com/KyoriPowered/indra/blob/main/3.x/indra-common/src/main/java/net/kyori/indra/internal/ModularityDetecter.java#L53-L117

I also discussed in the Adventure Discord. See https://discord.com/channels/319355592605040642/923221456073150525/1079701892550103040.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants