Addition of HEPMC3 and GENIE Reweight to docker image #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ketchum_HEPMC3
|
Saw two errors from running ctest: |
This was referenced Oct 16, 2024
There was a problem hiding this comment.
I do not know why there is a seg fault on the first event. I'm curious if it happens outside of ctest and if it does, then I'd do a Debug build of ldmx-sw and run the config in gdb to try to find the culprit.
Besides my question on Pythia6, I feel obliged to point out the OS update in the pipeline: #103 This would presumably require re-development of these changes, although that OS update also requires updates to ldmx-sw.
Dockerfile
Outdated
| @@ -214,6 +247,7 @@ RUN mkdir src &&\ | |||
| -Dxrootd=OFF \ | |||
| -Dgsl_shared=ON \ | |||
| -Dmathmore=ON \ | |||
| -Dpythia8=ON \ | |||
| -Dpythia6=ON \ | |||
There was a problem hiding this comment.
Can we remove Pythia6? Is it still necessary?
There was a problem hiding this comment.
Unfortunately still necessary :/ I know the GENIE team is working on it, but I think the Pythia6 dependency is buried deep, and they've not fully extricated it yet. I will double-check to be sure, but unfortunately it's a case where it looks like we need both.
There was a problem hiding this comment.
Just FYI, ROOT 6.32 does not support Pythia6
|
Thanks @tomeichlersmith. I haven't had the chance to investigate the test failure in more detail yet, but will do so. Good to verify that they should not be failing. I'll review the OS updates as well and work to make sure we have the right plan for that. |
|
OK, with a fresh environment / pulling down ldmx-sw trunk, I can properly build with the docker container and the ctests pass: Working on the various |
not sure if this will work, but I'm hoping it does
4 tasks
drop GENIE and its dep LHAPDF (for now), trying to get a build on DockerHub so its easier to test run the new OS and updated ROOT on other computers
need geom target for TH2Poly
|
OK, in response to #103 , I've updated the container here to be based off of branch I can get an ldmx-sw using this to compile, but in running tests I find that the HCal tests fail with many errors like: |
|
This error could be related to a recent patch of ldmx-sw where we updated the chip emulator. I'm not worried about it tbh, I'd rather get all of this work on |
|
After talking more with @wesketchum on slack, we agreed to just merge this PR and #103 so we can have a centrally produced image from which to test. I am going to work on doing that now with my ✨ unlimited admin powers ✨ |
tomeichlersmith
added a commit
that referenced
this pull request
Feb 27, 2025
commit ae2d54884f9ebcd236348fbb9e991c3602c0b51c Merge: 1d8cacc d619ac7 Author: tomeichlersmith <eichl008@umn.edu> Date: Thu Feb 27 09:45:59 2025 -0600 Merge branch 'main' into wketchum_HEPMC3 While fixing merge conflicts, update the SHELL to avoid bash since that is a docker-specific container file command. commit 1d8cacc Author: Wesley Ketchum <wesketchum@gmail.com> Date: Mon Feb 24 13:31:19 2025 +0100 update pythia8 and lhapdf minor versions, use tagged GENIE from wesketchum repo commit b125a30 Merge: 944e3ff ee74eb2 Author: Wesley Ketchum <wesketchum@gmail.com> Date: Mon Feb 24 11:31:54 2025 +0100 Merge remote-tracking branch 'ldmx/iss102-os-update' into wketchum_HEPMC_NoPythia6 commit 944e3ff Author: Wesley Ketchum <wesketchum@gmail.com> Date: Mon Feb 24 11:30:54 2025 +0100 update root options to work with genie build commit ee74eb2 Author: tomeichlersmith <eichl008@umn.edu> Date: Fri Feb 21 15:13:11 2025 -0600 cant comment in Dockerfile like a script :angry: commit d849cfe Author: tomeichlersmith <eichl008@umn.edu> Date: Fri Feb 21 15:08:56 2025 -0600 bump patch of ROOT built, include geom target need geom target for TH2Poly commit 3158df3 Merge: 5daca69 4d3efe2 Author: Wesley Ketchum <wesketchum@gmail.com> Date: Wed Feb 19 15:12:14 2025 +0100 Merge remote-tracking branch 'ldmx/iss102-os-update' into wketchum_HEPMC_NoPythia6 commit 5daca69 Author: Wesley Ketchum <wesketchum@gmail.com> Date: Wed Feb 19 15:09:37 2025 +0100 updates for removing Pythia6 commit 4d3efe2 Author: tomeichlersmith <eichl008@umn.edu> Date: Thu Jan 30 11:51:04 2025 -0600 bump ROOT to RNTuple standardized 6.34 drop GENIE and its dep LHAPDF (for now), trying to get a build on DockerHub so its easier to test run the new OS and updated ROOT on other computers commit b46aba5 Author: tomeichlersmith <eichl008@umn.edu> Date: Wed Jan 29 11:40:04 2025 -0600 blindly re-enable LHAPDF and GENIE not sure if this will work, but I'm hoping it does commit ecc26b3 Author: tomeichlersmith <eichl008@umn.edu> Date: Tue Jan 28 13:59:40 2025 -0600 remove development layer naming commit 1050f15 Author: tomeichlersmith <eichl008@umn.edu> Date: Tue Jan 28 13:55:24 2025 -0600 restore manual building of ROOT and Pythia for C++20 commit faf2f4a Author: Wesley Ketchum <wesketchum@gmail.com> Date: Wed Oct 16 09:53:01 2024 +0200 update genie downloads to be based on set tags commit ec924e1 Merge: e76a8e4 1c729e2 Author: Wesley Ketchum <wesketchum@gmail.com> Date: Tue Oct 8 14:04:02 2024 +0200 Merge branch 'main' of https://github.com/LDMX-Software/docker into wketchum_HEPMC3 commit f3275d4 Author: Tamas Vami <tamas.almos.vami@cern.ch> Date: Tue Sep 24 11:33:19 2024 -0700 Update OS to Ubuntu 24.04 and ROOT to 6.32.04 commit e76a8e4 Author: Wesley Ketchum <wesketchum@gmail.com> Date: Thu Jul 25 15:47:14 2024 +0200 updates for reweight, and pyhepmc3 commit 88fe974 Author: Wesley Ketchum <wesketchum@gmail.com> Date: Thu May 2 14:06:26 2024 +0200 updates to use hepmc3 as a medium for storing the GENIE event information commit d092470 Merge: 8fd6c80 7db19f6 Author: Wesley Ketchum <wesketchum@gmail.com> Date: Wed Feb 21 20:16:08 2024 +0100 Merge remote-tracking branch 'ldmx/main' commit 8fd6c80 Merge: fff90a3 2568c9f Author: Wesley Ketchum <wesketchum@gmail.com> Date: Sun Jan 7 13:02:03 2024 -0600 Merge branch 'main' of https://github.com/LDMX-Software/docker commit fff90a3 Merge: 274fbe1 93cad7e Author: Wesley Ketchum <wesketchum@gmail.com> Date: Thu Sep 28 15:27:09 2023 +0200 Merge branch 'main' of https://github.com/wesketchum/ldmxsw_docker commit 274fbe1 Author: Wesley Ketchum <wesketchum@gmail.com> Date: Thu Sep 28 15:23:17 2023 +0200 updates for GENIE with pythia8 and reweight commit a8eda4b Author: Wesley Ketchum <wesketchum@gmail.com> Date: Thu Sep 14 14:23:48 2023 -0500 missed a line on the merge conflict commit 340a75e Merge: ed8f2d3 e520b87 Author: Wesley Ketchum <wesketchum@gmail.com> Date: Thu Sep 14 14:22:47 2023 -0500 Merge branch 'main' of https://github.com/LDMX-Software/docker commit ed8f2d3 Author: Wesley Ketchum <wesketchum@gmail.com> Date: Thu Sep 14 14:17:30 2023 -0500 updates to GENIE for reweight/updated container
|
I did a command line squash merge in order to bypass the conflicts that exist on this branch that are eventually removed (e.g. attempts with Pythia6 and the like). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the addition of the HEPMC3 package, addition of Pythia8 for future interfaces to GENIE, updates to GENIE to include interfaces to HEPMC3, and the inclusion of the GENIE Reweight package.
What new packages does this PR add to the development container?
Check List
Following the above instructions, I saw two errors. Will include in following message.
Executed updated GENIE simulation and reweighting (from branch
wketchum/Genie_Generator_HepMC3Refactorin ldmx-sw) and verified all appears to be working well.