Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI does not fail if there is a fatal error in fire #1540

Closed
tvami opened this issue Jan 27, 2025 · 0 comments · Fixed by #1541
Closed

CI does not fail if there is a fatal error in fire #1540

tvami opened this issue Jan 27, 2025 · 0 comments · Fixed by #1541
Assignees
@tvami
Labels
github_actions Pull requests that update GitHub Actions code validation

Comments

@tvami
Copy link
Member

tvami commented Jan 27, 2025

Describe the bug

Even tho ldmx gives a fatal error the CI
https://github.com/LDMX-Software/ldmx-sw/blob/trunk/.github/workflows/pr_validation.yml
still goes on and actually returns success instead of failing.

To Reproduce
See #1515 (review)

Desired behavior

Fail if there is a failure...
@tvami tvami added github_actions Pull requests that update GitHub Actions code validation labels Jan 27, 2025
@tvami tvami self-assigned this Jan 27, 2025
@tvami tvami mentioned this issue Jan 27, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tvami tvami

Labels
github_actions Pull requests that update GitHub Actions code validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail validation CI if errors occur in validate action LDMX-Software/ldmx-sw
1 participant
@tvami