Update hcal prototype in reduced LDMX

[cmantill]

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves #1512

Check List

• I successfully compiled ldmx-sw with my developments

• I ran my developments and the following shows that they are successful:
  I used geant4 GDML reader (https://gitlab.cern.ch/geant4/geant4/tree/f18089fbc5147e33302b542e1135ebda79fcf18b/examples/extended/persistency/gdml/G01) in the updated ldmx-reduced-v2 directory.
  It compiled without problems (i.e. all variables/constants/volumes) are defined.

• I visualized the changes
  I do not have a nice *.mac file so that I can visualize the volumes. If anyone has that and could share it, that would be awesome.

[tvami]

so when we try to run this inside ldmx-sw we get

Evaluator : unknown variable
Aborted (core dumped)

I looked for hours now which of these could be unknown, but I didnt find it :/

[cmantill]

What kind of test is running that gives: "Evaluator : unknown variable"?

[tvami]

wget https://raw.githubusercontent.com/LDMX-Software/ldmx-sw/e375990bf13c7073634bf2eab3bff7e84a9d991b/.github/validation_samples/reduced_ldmx/config.py
just setenv LDMX_NUM_EVENTS=1
just setenv LDMX_RUN_NUMBER=1
just fire config.py

[tvami]

@cmantill can you confirm that you can reproduce the error?

[tvami]

OK, so I found two things:

• the config fails bc of the scoring planes, probably there is some overlap there --> if I switch if off, it works, see 280d315
• To check the overlap I tried to validated the detector, well, see The validate_detector is broken #1533

I think after the CI finishes I'm ready to sign this

[cmantill]

So you are OK with not having SPs for now?

[tvami]

So you are OK with not having SPs for now?

Yes, unless you see where the problem is already, then let's fix it; otherwise having the SP is less crucial (right @SanjitMasanam , do you use the SP for anything at this point?)

[SanjitMasanam]

Correct, I don't use the SP for my studies so excluding them will be fine!

[tvami]

OK it technically works, but we lost a lot of ECAL which makes no sense since only the HCAL was modified, I'm worried it might be because of the overlay

CI results are in https://github.com/LDMX-Software/ldmx-sw/actions/runs/12956457526?pr=1515

[tvami]

With the new gold
https://github.com/LDMX-Software/ldmx-sw/actions/runs/12961371139?pr=1515
Red looks like the old blue

I dont really understand why these fluctuate back and forth, but the blue in this PR looks reasonable... We need to look into this in details, but I'm ok to merge this as is for now

[tvami]

Looks good
https://github.com/LDMX-Software/ldmx-sw/actions/runs/12997477816?pr=1515

[tvami]

Actually (after Sanjit pointed out), the logs do say a bad config

[ ElectronCounter ] 762  info: Found 1 electrons (tracks) using input collection TriggerPadTracksY_
[ trigger ] 762  info: Got trigger energy cut 1500 for 1 electrons counted in the event.
[ trigger ] 762  info: Got trigger energy sum 5.31643; and decision is pass = true
[ TrigScintDigiPad1 ] 762 debug: Looping over hits in trigScintDigisPad1
[ TrigScintDigiPad2 ] 762 debug: Looping over hits in trigScintDigisPad2
[ TrigScintDigiPad3 ] 762 debug: Looping over hits in trigScintDigisPad3
[ fire ] 763 fatal: [BadConf] : Relative cell coordinates (-85.10, -30.82) mm derived from world coordinates (-30.82, 85.10) mm with layer = 0 and module = 0 are outside module hexagon
  at /home/runner/work/ldmx-sw/ldmx-sw/DetDescr/src/DetDescr/EcalGeometry.cxx:174 in getID

we really need to fix that the CI fails if fire returns fatal, @tomeichlersmith

[tvami]

OK so we established that w/o this change the ecal part looks fine and run, with this change the ecal geometry is messed up... I do not understand how that's possible when we only add HCAL here...