Modified the LYSO target design #1498
Conversation
|
Hi Sam, To help us understand how you know that your changes are good, please upload some plots in this discussion thread, explain what you ran to get them, and what they show. (This is the purpose of the second box, that you already checked when you made the PR. I unchecked it until you have shared some more material.) |
|
I implemented the following geometry:
|
There was a problem hiding this comment.
Thank you for the images! Those look great :)
I just want to confirm that this runs and the geometry doesn't have any sneaky issues (e.g. overlaps that are not visible because they are small but could cause issues during the simulation). Can you share a configuration you've used to confirm that this geometry successfully runs a simulation?
We can then run the same configuration with
# sim is the simulator configuration object already created
sim.validate_detector = True
sim.verbosity = 5so that ldmx-sw takes extra time to make sure the geometry is valid.
|
I have talked to Dr. James Oyang, @joyang8caltech, and he agreed to run some simulations using this geometry. Dr. Oyang, I forked a version of ldmx-sw into my github account and made the geometry modifications. It is at https://github.com/zwl0331/ldmx-sw You can clone it to run simulations with it. |
There was a problem hiding this comment.
Sorry it took me some time to look at this (DR writing...), I made some suggestions / questions in below.
Generarly I'd really like to see some tests that use this geometry, furthermore I'd suggest to either copy or rename the whole directory to r2, i.e. ldmx-lyso-r2-v14-8gev the r was for the revision, so it was exactly meant for this purposes. If you chose to rename, please add the info in the README that v4.1.4 is the last one to have ldmx-lyso-r1-v14-8gev
How is this going? Please see the specific geometry validation instructions posted here by @tomeichlersmith. I also wonder, @tomeichlersmith and @tvami, if we should have a validation workflow for geometry changes? (This is not the last time we'll make an update.) We do expect a whole lot of changes to distributions, so it's not clear what tests are meaningful, apart from that things run, and the overlap check tom mentioned. |
|
By the way @zwl0331, @joyang8caltech, the plastic geometry doesn't look right. We expect to have 24 bars in each plastics array, so they are equal height but staggered in y. |
|
We need to have thirty two 3mm height and 40mm long LYSO bars so that the active LYSO target will have the same coverage as tungsten target.
On Dec 16, 2024, at 6:17 AM, bryngemark ***@***.***> wrote:
By the way @zwl0331<https://github.com/zwl0331>, @joyang8caltech<https://github.com/joyang8caltech>, the plastic geometry doesn't look right. We expect to have 24 bars in each plastics array, so they are equal height but staggered in y.
—
Reply to this email directly, view it on GitHub<#1498 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A24FEATKUB4RTRRVJDB5Q4T2F3OI5AVCNFSM6AAAAABSNDXYUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBVG42DOOJYGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I agree we need this, but I think we should have this after the sensitive volumes are defined, then we can do a PN sample with LYSO in the CI The validate_detector doesnt work, see #1533 So we need to do this semi-blind... @zwl0331 can you please update the code with the comments from me and Tom? |
|
I have successfully built ldmx-sw with the new geometry ran a simple simulation with it. Here is the simulation configuration: The simulation ran successfully, giving the following output: |
Sorry about this. I put up the wrong figures. The correct ones are these. As you can see, they are 24 bars on both TS layers and they are staggered in y. |
|
There are two points of confusion with your configuration. sim.validate_detector = True
sim.verbosity = 5As written, this won't work. mySim.setDetector( 'ldmx-det-v14-8gev' , True )This is saying to run the simulation with the |
|
Unrelated, you can avoid having to use https://docs.docker.com/engine/install/linux-postinstall/#manage-docker-as-a-non-root-user |
|
thanks @zwl0331 for sharing your config file! as you can see this was a great way to catch some issues with your validation procedure. |
Thanks for the comments! This is the new simulation configuration I ran: from LDMX.Framework import ldmxcfg
p = ldmxcfg.Process( "sim" )
import sys
p.maxEvents = 10 #Note: use small number as you really are just checking the geom
if len(sys.argv) > 1 :
p.maxEvents = int(sys.argv[1])
# we want to see every event
p.logFrequency = 1 if p.maxEvents <= 10 else 100
p.termLogLevel = 1
# Set a run number
p.run = 9001
p.outputFiles = [ "elecGun_8GeV.root" ]
from LDMX.SimCore import simulator as sim
import LDMX.Ecal.EcalGeometry
import LDMX.Hcal.HcalGeometry
mySim = sim.simulator( "mySim" )
mySim.setDetector( 'ldmx-lyso-r2-v14-8gev' , True )
#sim.beamSpotSmear = [20., 80., 0.]
# Get a pre-written generator
from LDMX.SimCore import generators as gen
myGun = gen.single_8gev_e_upstream_tagger()
mySim.generators.append( myGun )
# sim is the simulator configuration object already created--> From Tom
sim.validate_detector = True
sim.verbosity = 5
# add your configured simulation to the sequence
p.sequence.append( mySim )
# #Note: reco stuff --> use what you need, probably you dont care too much about this stuff
import LDMX.Ecal.EcalGeometry
import LDMX.Ecal.ecal_hardcoded_conditions
import LDMX.Hcal.HcalGeometry
import LDMX.Hcal.hcal_hardcoded_conditions
import LDMX.Ecal.digi as ecal_digi
import LDMX.Ecal.vetos as ecal_vetos
import LDMX.Hcal.digi as hcal_digi
from LDMX.Hcal import hcal_trig_digi
from LDMX.Ecal import ecal_trig_digi
from LDMX.Hcal import hcal
p.sequence.extend([
ecal_digi.EcalDigiProducer(),
ecal_digi.EcalRecProducer(),
hcal_digi.HcalDigiProducer(),
hcal_digi.HcalRecProducer()
])And it ran successfully: |
|
I'd like to point out that
|
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #1370 and implements the new design for the LYSO target. It consiste of two layers. The first layer has 32 bar, while the second has 33 bars.
Check List