-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize ecal biasing factor for 8 GeV #1566
base: trunk
Are you sure you want to change the base?
Conversation
I'm gonna use this PR to test #1569 |
/run-validation |
The validation workflow is running here: https://github.com/LDMX-Software/ldmx-sw/actions/runs/13140056694. |
I think this works now! |
I'll test if it also works in a draft mode |
/run-validation |
The validation workflow is running here: https://github.com/LDMX-Software/ldmx-sw/actions/runs/13140159042. |
Yaay it does! Sorry everybody if you got more than than a dozen msg because of this! |
I'm opening this for review, as we agreed today that this will not affect anything in the DR and is safe to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk... do we want to wait and see if we are really over-biasing a high energy child-of-primary photon? I'm thinking that maybe there is a bug in our checks on which particles get biased...
Here is the rest of the KS-failed distributions: |
With a factor 1000 it looks like we're getting about 10% more events in the first two bins than we used to (btw is the reference with 8 GeV/550, or 4 GeV/450?). I think this could still mean that we're getting a large enough xsc to trigger a warning but it is suppressed. Did you get around to running with |
with ref to 8 GeV/550
Not yet, but sounds good |
I suggest we discuss this at the sw dev meeting today and type up what we learn from that and the email thread with natalia in this issue afterwards. |
Let's test with the new gold |
The rest of the plots that fail the KS (reminder the red is with 550 and the blue is with 1000) |
Results in https://github.com/LDMX-Software/ldmx-sw/actions/runs/13469761175 The z with using biasing factor of 5000 ![]() So more is happening now in the non-W based elements, I guess this was expected |
I'll check now how things look like for biasing factor of 1 |
Ohh so with biasing factor of 1 the ecalPN takes longer than 6 hours to run, so github kills it... |
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Resolves #1535
Check List
See #1535 (comment)