Skip to content

Commit a4f31d8

Browse files
authored
Merge pull request #321 from LDSSA/feature/card#319_v2
Feature/card#319 v2
2 parents 5aae548 + 277cd5a commit a4f31d8

File tree

5 files changed

+2
-7
lines changed

5 files changed

+2
-7
lines changed

__init__.py

Whitespace-only changes.

portal/__init__.py

Whitespace-only changes.

portal/portal/__init__.py

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

portal/portal/academy/views.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ class StudentUnitDetailView(StudentViewsMixin, BaseUnitDetailView):
141141
class InstructorUserListView(InstructorViewsMixin, ListView):
142142
model = get_user_model()
143143
queryset = model.objects.filter(is_student=True, failed_or_dropped=False)
144-
#queryset = get_user_model().objects.filter(is_student=True, failed_or_dropped=False)
144+
145145
template_name = "academy/instructor/user_list.html"
146146

147147
def get_queryset(self):

portal/portal/templates/academy/instructor/user_list.html

-6
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ <h1><a href="{% url 'academy:instructor-user-list' %}" class="text-dark" title="
1818
<thead>
1919
<tr>
2020
<th scope="col" rowspan="2">Name</th>
21-
{% comment %}
22-
<th scope="col" rowspan="2">Slack</th>
23-
{% endcomment %}
2421
<th scope="col" rowspan="2">Submission Date</th>
2522
<th scope="col" rowspan="2">Total</th>
2623
<th scope="col" rowspan="2">Eligible for graduation</th>
@@ -40,9 +37,6 @@ <h1><a href="{% url 'academy:instructor-user-list' %}" class="text-dark" title="
4037
{% for obj in object_list %}
4138
<tr>
4239
<th><a href="{% add_query_param 'user_id' obj.user.id %}" class="text-dark" title="Filter by student">{{ obj.user.first_name }} {{ obj.user.last_name }}</a></th>
43-
{% comment %}
44-
<td><a href="{{ workspace_url }}{{ obj.user.slack_member_id }}" target="_blank" class="text-dark">{{ obj.user.slack_member_id }}</a></td>
45-
{% endcomment %}
4640
<td><a href="{% add_query_param 'submission_date' obj.submission_date %}" class="text-dark"> {{ obj.submission_date }} </a></td>
4741
<td><a href="{% add_query_param 'score__gte' obj.total_score %}" class="text-dark">{{ obj.total_score }}&#47;{{ max_score }}</a></td>
4842
<th><a href="{% add_query_param 'can_graduate' obj.user.can_graduate %}" class="text-dark" title="Filter by graduation status">{% if obj.user.can_graduate %}Yes{% else %}No{% endif %}</a></th>

0 commit comments

Comments
 (0)