Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admissions bugs and improvements #117

Closed
dominguezmaria opened this issue Jun 20, 2021 · 1 comment
Closed

Admissions bugs and improvements #117

dominguezmaria opened this issue Jun 20, 2021 · 1 comment

Comments

@dominguezmaria
Copy link
Contributor

dominguezmaria commented Jun 20, 2021

These issues are order from the most important to the less important.
However, since tomorrow starts the applications phase, and the payments phase is only in two weeks, the ones that are more useful to have now are: 1 (super important), 4 and 7.

1. I can submit the coding test after time is up

The state is still admissions:applications because the selection period will only start on the 22nd.
The coding test duration is set to 5 minutes.
I started the coding test, and after 5 minutes, the submissions page in the portal shows me this, which is correct:

Screen Shot 2021-06-20 at 12 03 01

However, I can still make submissions, including passing the test, after my test time is over:

Screen Shot 2021-06-20 at 12 03 27

Screen Shot 2021-06-20 at 12 05 45


2. Submit student ID

On the candidate version of the portal, on the payments page (https://portal-staging.lisbondatascience.org/admissions/candidate/payment), when the candidate is a student, we need a box for the candidate to upload the student ID

Screen Shot 2021-06-19 at 18 30 36


3. Reset payment

On the staff version of the portal, on a payment page, there is an option to reset payment.
Sometimes candidates select one ticket type, but then need to change it. Example: a candidate selected student but now can't prove they're a student so they need to change the ticket type to regular. Or someone learned now that their company is willing to pay for their ticket. Or a candidate selected the wrong ticket type. This happens every year.

This reset payment option worked like this:

  • the candidate could change their ticket type on the profile
  • the staff would click reset payment and a new payment would be generated with the updated value
  • on the portal, the student would see the correct amount

Example: https://portal-staging.lisbondatascience.org/admissions/staff/payments/6
Screen Shot 2021-06-20 at 11 19 57

I tried the reset payment and it gave me 500 error.

It's ok if we can't fix the "Reset" feature as long as we can change the ticket type and update the payment on the back office.


4. Feedback with scores

Last year the feedback that we provided to the candidates on their submissions had the scores for each question.
Note the scores summary at the top of the page and the score in each question.

Screen Shot 2021-06-20 at 11 47 59
Screen Shot 2021-06-20 at 11 47 52

Now the feedback doesn't include the scores:

Screen Shot 2021-06-20 at 11 50 45

Screen Shot 2021-06-20 at 11 50 38

(GitHub doesn't allow me to update an html file, I can send it over for a more complete example!)


5. Emails from admissions@lisbondatascience.org

All the emails sent from the portal should have from = admissions@lisbondatascience.org. This is because in all the communications we're asking candidates to add this email address to their contact lists, in order to avoid SMAP.
Currently the confirm email and reset password emails are being sent from notification@lisbondatascience.org.


6. Payments tab missing on nav bar

On the candidate version of the portal, on the home page. We're in the admissions:selection state, and the candidate was selected, meaning he now has to pay the fee.
The nav bar is missing the payments tab.

Screen Shot 2021-06-20 at 11 30 10

Screen Shot 2021-06-20 at 11 30 05


7. Time to finish the coding test

On the candidate version of the portal, on the home page, in the applications phase, we often say that the candidate has X hours to complete the test. But this is being displayed as: you only have 3:00:00 to finish it.

It would be clearer if we said you only have 3 hours to finish it.

The admissions test duration will always be in hours, so we could transform this duration into hours and present it always like X hours. Even if it's 3.5 hours, I think it looks better than you only have 3:30:00 to finish it.


8. Can't see my submissions when state moves to admissions:selection

On the candidate version of the portal, after the applications are over, the submissions pages are not accessible anymore.
Ideally, we should allow the candidates to see their submissions, but don't allow them to submit anymore.

hcastilho added a commit that referenced this issue Jun 20, 2021
hcastilho added a commit that referenced this issue Jun 20, 2021
@cimendes cimendes added this to the batch6 milestone Aug 9, 2021
@hcastilho hcastilho changed the title Portal bugs and improvements Admissions bugs and improvements Aug 19, 2021
@cimendes
Copy link
Member

This needs to be broken into several independent issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants