File uses global instead of globalThis

[gilbert]

Is there an existing issue for this?

• I have searched the existing issues

SDK version

3.0.32, but issue exists on master

Lit Network

N/A, trying to bundle package for browser

Description of the bug/issue

Can't find variable: global
../../node_modules/@lit-protocol/auth-browser/src/lib/chains/eth.js

which points to this line

Severity of the bug

Can't bundle for browser in a create-react-app

Steps To Reproduce

Using globalThis instead of global fixes the problem. The rest of the file also uses globalThis, so this would maintain consistency.

Link to code

No response

Anything else?

No response

[joshLong145]

thanks for calling this out! Nice find.

[gilbert]

FYI the issue isn't fixed yet. The error was that global is not defined. The change in the PR...

- if (typeof global.Buffer === 'undefined') {
+ if (global && typeof global.Buffer === 'undefined') {

...still attempts to use the global variable, which will still produce the error.

The solution is to replace all usage of global with globalThis. The MDN article describes why you only need globalThis:

Unlike similar properties such as window and self [and global], globalThis is guaranteed to work in window and non-window contexts. In this way, you can access the global object in a consistent manner without having to know which environment the code is being run in.