Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref/remove execute with retry #497

Merged
merged 11 commits into from
Jun 5, 2024
Merged

Conversation

joshLong145
Copy link

Description

Removes 'executeWithRetry` as we are more stable when performing

  • executeJs
  • pkpSign
  • decrypt
  • runOnTargetNodes
  • signSessionKey

Note: retrying internal network calls which are required for stand up will be added back in an up coming pr.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested with local-tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@joshLong145 joshLong145 requested a review from Ansonhkg as a code owner June 5, 2024 14:54
Ansonhkg

This comment was marked as duplicate.

@Ansonhkg Ansonhkg self-requested a review June 5, 2024 15:01
Ansonhkg

This comment was marked as resolved.

@Ansonhkg Ansonhkg self-requested a review June 5, 2024 15:03
Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a build error with RetryTolerance in the CI, i think we need to remove it from misc.ts

Compiling TypeScript files for project "misc"...
packages/misc/src/lib/misc.ts:30:3 - error TS2305: Module '"@lit-protocol/types"' has no exported member 'RetryTolerance'.

30   RetryTolerance,
     ~~~~~~~~~~~~~~

: 

@joshLong145 joshLong145 requested a review from Ansonhkg June 5, 2024 15:18
Ansonhkg
Ansonhkg previously approved these changes Jun 5, 2024
@joshLong145 joshLong145 merged commit 844d9a0 into master Jun 5, 2024
4 checks passed
@joshLong145 joshLong145 deleted the ref/remove-execute-with-retry branch June 5, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants