Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): contract context #505

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix(core): contract context #505

merged 1 commit into from
Jun 12, 2024

Conversation

joshLong145
Copy link

Fixes a small bug from pr #502 where we would not respect the contractResolver address if provided which breaks some local development flows.

@joshLong145 joshLong145 requested a review from Ansonhkg as a code owner June 12, 2024 15:01
Ansonhkg
Ansonhkg approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@Ansonhkg Ansonhkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Thanks!

@joshLong145 joshLong145 merged commit 4757a2f into master Jun 12, 2024
4 checks passed
@joshLong145 joshLong145 deleted the fix/contract-context-check branch June 12, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ansonhkg Ansonhkg Ansonhkg approved these changes

@MaximusHaximus MaximusHaximus Awaiting requested review from MaximusHaximus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshLong145 @Ansonhkg