Feature/3404 datil dev support #515

Ansonhkg · 2024-06-27T14:43:58Z

Changelog

🚀 Features

(tinny) Introduce chunked parallel execution
(tinny) LIT_RPC enum
*(tinny)*Add relayer tests
(sdk) Add datil relayer support

🐛 Bug Fixes

Import
(testing) Correct test result reporting in runTestsParallel
(tinny) Temp disabled wallet switching when minting pkp
(tinny) Temp disabled switchWallet when minting capacity delegation authsig
(tinny) Simplify and centralize RPC URL handling

📚 Documentation

Update local-test README

⚙️ Miscellaneous Tasks

Fix testLIT typo

Dev

(test) Add env file for local tests and dotenv
(test) Add .env
(test) Add lock file
Add shiva types defs
(shiva) Update shiva client

Description

Follow up from Hwrdtm/datil dev support #510

Installation

yarn add @lit-protocol/lit-node-client@datil-dev

or

yarn add @lit-protocol/lit-node-client@6.1.0-beta.0

Using the `datil-dev` network

const litNodeClient = new LitNodeClient({
  litNetwork: "datil-dev",
});

await litNodeClient.connect();

Test command:

❗️❗️Note: I'm failing to run the tests in parallel right now, but they work when running individually. I added a CHUNK_SIZE feature which would run parallel execution in chunks and I thought that would fix it, but it seems like it might be RPC rate limit issue instead of nonce? not sure.. still to be investigated...❗️❗️

UPDATE: contract calls still being reverted, but if gasLimit is set to 5 mil, then parallel executions work fine

DEBUG=true NETWORK=datil-dev yarn test:local

Related PRs:

Relayer: Implement support for datil-dev relay-server#46
General Worker: feat: add datil-dev network lit-apps#18
DatilDev Faucet: https://github.com/LIT-Protocol/faucet-app/pull/10

…ort multiple Lit RPCs

…pport

- Remove incorrect "All tests passed" message when failures occur - Add detailed reporting for passed and failed tests - Include test count in final report - Ensure "All tests passed" only shows when all tests actually pass

MaximusHaximus

👍 Nice work on quick notice, man. Nice enhancements to the local tests too. I added a bunch of nits, but did have a couple of things that I think might be breaking changes that I added comments on too 👍

.env.sample

local-tests/README.md

local-tests/setup/shiva-client.d.ts

local-tests/setup/shiva-client.ts

packages/contracts-sdk/src/lib/contracts-sdk.ts

packages/lit-auth-client/src/lib/lit-auth-client.ts

packages/types/src/lib/types.ts

Co-authored-by: Daryl Collins <daryl@litprotocol.com> Signed-off-by: Anson <ansonox@gmail.com>

…4b071781f58c95076269b1a7a628cb#r1659269933

…4b071781f58c95076269b1a7a628cb#r1659270019

…4b071781f58c95076269b1a7a628cb#r1659265223

…4b071781f58c95076269b1a7a628cb#r1659268041

…4b071781f58c95076269b1a7a628cb#r1659270163

…4b071781f58c95076269b1a7a628cb#r1659272508

…4b071781f58c95076269b1a7a628cb#r1659270231

…anual-gas-limit Signed-off-by: Anson <ansonox@gmail.com>

…m/LIT-Protocol/js-sdk into feature/3404-add-manual-gas-limit

…-limit feat: add custom gas limit

…feature/3404-datil-dev-support

… keys

…ort-wrappedkeys LIT-3404 - Add Wrapped Keys support for datil-dev

…make defaulting + required states for SEV checks more explicit.

…ecution are readable - We no longer re-throw a new error with a message containing the stringified error - Error objects stringify to { } so this was destroying our ability to read errors from the `postLitActionValidation()` method

…eGeneratedSessionSigsToEncryptDecryptString

…mpatibility - Moved into a sub-directory for clarity and less wall-of-text on root `tests` directory - Added helper method to handle setting gas and chain parameters depending on the network we're running against - Updated logging to not show fail X's when the tests are passing - Un-commented disabled test for checking duplicate private key being stored to wrapped-keys backend - Removed test checking insufficient funds; this was not actually testing our code, only ethers.

…tests to match reality

…hertext` for keys that we work with from our built-in LIT actions

Since we merged the Wrapped Keys support for Datil-dev

Publishing the same build with the @datil-dev tag

… is called on Habanero

MaximusHaximus

👍 LGTM

hwrdtm · 2024-07-25T04:06:08Z

packages/contracts-sdk/src/lib/contracts-sdk.ts

    context?: LitContractContext | LitContractResolverContext,
    rpcUrl?: string
  ) {
    let provider: ethers.providers.JsonRpcProvider;
-    rpcUrl = rpcUrl ?? DEFAULT_READ_RPC;
+    rpcUrl =
+      rpcUrl ?? network === 'datil-dev' ? LIT_RPC.VESUVIUS : LIT_RPC.CHRONICLE;


I think this is a bug. The following yields different result, and which is what (I think) we want instead.

rpcUrl = rpcUrl ?? (network === 'datil-dev' ? LIT_RPC.VESUVIUS : LIT_RPC.CHRONICLE);

hwrdtm and others added 10 commits June 19, 2024 21:16

Implement support for running against datil-dev

91278c8

Hack to make work against datil-dev

7ce9b5e

feat(tinny): remove LIT_OFFICIAL_RPC and add LIT_RPC enum to supp…

b5df915

…ort multiple Lit RPCs

chore: fix testLIT typo

26d181c

fix: import

0f4065c

Merge branch 'dev/test-common-updates' into feature/3404-datil-dev-su…

0f5d175

…pport

feat(test): introduce chunked parallel execution

1d66ed0

fix(temp): disabled switchWallet

1928396

feat(test): LIT_RPC enum

fcc0fe2

Ansonhkg mentioned this pull request Jun 28, 2024

feat: add datil-dev network LIT-Protocol/lit-apps#18

Merged

4 tasks

Ansonhkg added 3 commits June 28, 2024 16:31

feat: add relayer tests

e6139c1

feat(tinny): temp disabled wallet switching

155cacb

feat: add datil relayer support

0fb62e3

Ansonhkg marked this pull request as ready for review June 28, 2024 16:21

Ansonhkg requested a review from joshLong145 as a code owner June 28, 2024 16:21

Ansonhkg requested a review from DashKash54 June 28, 2024 16:22

Ansonhkg added 2 commits June 28, 2024 18:27

fix(tinny): Simplify and centralize RPC URL handling

bfe0cac

fix(contracts-sdk): correct rpc for browser

83c7382

MaximusHaximus requested changes Jun 28, 2024

View reviewed changes

Ansonhkg and others added 10 commits June 28, 2024 21:24

Update local-tests/README.md

3e25698

Co-authored-by: Daryl Collins <daryl@litprotocol.com> Signed-off-by: Anson <ansonox@gmail.com>

Update local-tests/README.md

462d886

Co-authored-by: Daryl Collins <daryl@litprotocol.com> Signed-off-by: Anson <ansonox@gmail.com>

Update local-tests/setup/shiva-client.ts

d7fdea8

Co-authored-by: Daryl Collins <daryl@litprotocol.com> Signed-off-by: Anson <ansonox@gmail.com>

fix: https://github.com/LIT-Protocol/js-sdk/pull/515/files/83c73821c5…

efd7404

…4b071781f58c95076269b1a7a628cb#r1659269933

fix: https://github.com/LIT-Protocol/js-sdk/pull/515/files/83c73821c5…

a82fe0b

…4b071781f58c95076269b1a7a628cb#r1659270019

fix: https://github.com/LIT-Protocol/js-sdk/pull/515/files/83c73821c5…

8323088

…4b071781f58c95076269b1a7a628cb#r1659265223

fix: https://github.com/LIT-Protocol/js-sdk/pull/515/files/83c73821c5…

0cdddfd

…4b071781f58c95076269b1a7a628cb#r1659268041

fix: https://github.com/LIT-Protocol/js-sdk/pull/515/files/83c73821c5…

e254cfb

…4b071781f58c95076269b1a7a628cb#r1659270163

fix: https://github.com/LIT-Protocol/js-sdk/pull/515/files/83c73821c5…

9be5559

…4b071781f58c95076269b1a7a628cb#r1659272508

fix: https://github.com/LIT-Protocol/js-sdk/pull/515/files/83c73821c5…

b1db2e9

…4b071781f58c95076269b1a7a628cb#r1659270231

Ansonhkg added 9 commits July 2, 2024 17:49

Merge branch 'feature/3404-datil-dev-support' into feature/3404-add-m…

bc03da9

…anual-gas-limit Signed-off-by: Anson <ansonox@gmail.com>

chore: add comment

d8bd3e9

Merge branch 'feature/3404-add-manual-gas-limit' of https://github.co…

c212647

…m/LIT-Protocol/js-sdk into feature/3404-add-manual-gas-limit

fix: gasLimit missing on param

7450f8b

fix: param optionality

a6e145d

fix: upping default gas limit

2881f6e

Merge pull request #519 from LIT-Protocol/feature/3404-add-manual-gas…

ddb9982

…-limit feat: add custom gas limit

chore: prettier

2b2f120

Merge branch 'master' of https://github.com/LIT-Protocol/js-sdk into …

35add79

…feature/3404-datil-dev-support

Ansonhkg self-assigned this Jul 2, 2024

Ansonhkg and others added 9 commits July 2, 2024 19:44

fix: linty lint

2a0cdb6

feat(wrapped-keys): LIT-3404 - Add support for datil-dev to wrapped…

0f0ce25

… keys

Merge pull request #520 from LIT-Protocol/feature/3404-datil-dev-supp…

87ce2fd

…ort-wrappedkeys LIT-3404 - Add Wrapped Keys support for datil-dev

feat(lit-core): LIT-3404 - Ensure Datil processes Epoch changes, and …

3524f56

…make defaulting + required states for SEV checks more explicit.

fix(local-tests): LIT-3404 - Fix TS error in testUseValidLitActionCod…

9a4408d

…eGeneratedSessionSigsToEncryptDecryptString

test(wrapped-keys): LIT-3404 - Update error string checks on failing …

34d95b6

…tests to match reality

test(wrapped-keys): LIT-3404 - Enable generate key tests

f88591d

joshLong145 mentioned this pull request Jul 3, 2024

Feature/lit 3536 cleanup shiva changes #521

Merged

12 tasks

MaximusHaximus and others added 5 commits July 5, 2024 15:35

fix(wrapped-keys): LIT-3404 - Enforce salt is always included in `cip…

2fbd861

…hertext` for keys that we work with from our built-in LIT actions

Published version: 6.1.0@wrapped-keys

11051ad

Since we merged the Wrapped Keys support for Datil-dev

Published version: 6.1.0@datil-dev

221c264

Publishing the same build with the @datil-dev tag

refac: Prettier

53b0532

chore(wrapped-keys): LIT-3404 - Throw error if generatePrivateKey()…

51ca628

… is called on Habanero

MaximusHaximus approved these changes Jul 8, 2024

View reviewed changes

MaximusHaximus merged commit 31ff682 into master Jul 8, 2024
4 checks passed

MaximusHaximus deleted the feature/3404-datil-dev-support branch July 8, 2024 19:57

MaximusHaximus mentioned this pull request Jul 8, 2024

Publish version 6.1.0 #524

Merged

hwrdtm reviewed Jul 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/3404 datil dev support #515

Feature/3404 datil dev support #515

Ansonhkg commented Jun 27, 2024 •

edited

Loading

MaximusHaximus left a comment

MaximusHaximus left a comment

hwrdtm Jul 25, 2024

Feature/3404 datil dev support #515

Feature/3404 datil dev support #515

Conversation

Ansonhkg commented Jun 27, 2024 • edited Loading

Changelog

🚀 Features

🐛 Bug Fixes

📚 Documentation

⚙️ Miscellaneous Tasks

Dev

Description

Installation

Using the datil-dev network

Test command:

Related PRs:

MaximusHaximus left a comment

Choose a reason for hiding this comment

MaximusHaximus left a comment

Choose a reason for hiding this comment

hwrdtm Jul 25, 2024

Choose a reason for hiding this comment

Ansonhkg commented Jun 27, 2024 •

edited

Loading

Using the `datil-dev` network