V0.7.0 rc #916

bmhan12 · 2022-08-24T16:54:41Z

This PR:

A release candidate
The helper PR Diffs in V 0.7.0 release candidate with respect to develop #917 has this branch target develop as the base to merge into for easier diffs
- Adds comments and review to this PR for merging into main, Diffs in V 0.7.0 release candidate with respect to develop #917 is for viewing diffs.
Manual Github Actions Windows build is passing: https://github.com/LLNL/axom/actions/runs/2920543574

The bug was caused by re-using the ISendRequest before the request completed.

This is a step toward eventually shifting the communication code to conduit. The current computeClosestPoint still works.

Converted SLIC's logger container and active-logger pointer to a singleton class to guard against problems with initialization. Co-authored-by: Rich Hornung <hornung1@llnl.gov>

…und. It doesn't work in conjuction with thresholding, which is more effective.

…e-query-low-comm

…to our export list

Misc cleanup

Object mesh should not depend on number of MPI processes. Remove debug code.

This helps reduce memory use by non-blocking sends.

kennyweiss

Thanks @bmhan12 !

RELEASE

rhornung67

Overall looks great @bmhan12 Thank you. Please see my comments about citing all past contributors in #917

update SCR link

* Add CUDA option to using-with examples, add Serac workaround for cmake example * Add HIP option to using-with examples, add -lblt_hip_runtime workaround for cmake example Co-authored-by: Chris White <white238@llnl.gov>

bmhan12 · 2022-08-30T16:42:04Z

Looking to merge into main, but there are these two required checks in Azure that are still waiting for status to be reported:

LLNL.axom (Build_and_Test linux_gcc8)
LLNL.axom (Build_and_Test linux_gcc8_64bit)

These might be from main? These jobs don't appear in the triggered Azure run, as the azure-pipelines.yml was upgraded to test gcc11 instead of gcc8.

rhornung67 · 2022-08-30T17:14:25Z

@bmhan12 you are correct in that the azure builds for the main branch do gcc8, while develop (and this RC branch) do gcc11. I don't know how to resolve this. I would think that the CI would run on a version of the code with this branch merged into main.

kennyweiss · 2022-08-30T17:24:40Z

@bmhan12 you are correct in that the azure builds for the main branch do gcc8, while develop (and this RC branch) do gcc11. I don't know how to resolve this. I would think that the CI would run on a version of the code with this branch merged into main.

@white would probably know.
Perhaps we need a small patch PR into main to update the CI before merging in the RC branch?

bmhan12 · 2022-08-30T17:36:26Z

I was trying to see if maybe starting a run through Azure Pipelines GUI instead of triggered by commit would solve the issue, but I don't have that access in Azure. Can someone grant me access?

white238 · 2022-08-30T17:50:27Z

CI will run the jobs that are in the branch but Github protects the branch on specific jobs (which this branch is not running). The way around this is to verify manually we are okay with merging, then have an authorized person turn off the specific branch protection for these tests, merge, then turn on the new ones for future PRs.

This is to stop someone from turning off checks to get their PR in.

rhornung67 · 2022-08-30T18:02:44Z

I don't think we should do a small PR to main to update the CI since that would pollute main, which should only contain merges that reflect the release history. Let's do what Chris suggested. @bmhan12 please verify that the RC branch works on a TOSS system with gcc8. Then, we can turn off the branch permissions on main and merge the PR.

bmhan12 · 2022-08-30T18:08:32Z

@bmhan12 please verify that the RC branch works on a TOSS system with gcc8. Then, we can turn off the branch permissions on main and merge the PR.

Yes, as part of gitlab we test gcc 8 on ruby (TOSS3): https://lc.llnl.gov/gitlab/axom/axom/-/pipelines/203905

EDIT: I've also verified gcc 8 passes as part of running build_src.py on rzgenie.

jcs15c and others added 30 commits July 20, 2022 18:17

Made compatible with new interface

b731c83

Add split_to_convex, Polygon include

74779aa

Add point containment, new includes

e468e25

Minimized scratch work, cleaned interface

e0b8988

Fix the bug overwriting data in the last isend.

e3303ae

The bug was caused by re-using the ISendRequest before the request completed.

Cleaning up: Disable some debugging code.

29c2432

Gradually removing debugging code.

3f185bf

Switch from custom ISendRequest struct to conduit::relay::mpi::Request.

f20359d

This is a step toward eventually shifting the communication code to conduit. The current computeClosestPoint still works.

Improve example function

2c7a2b6

Remove operator dependencies

84f74c2

Clean up includes, calling interface

da3f962

Add standalone operators that work on Polygon

9fe64ae

Added tests for is_convex and in_polygon

7833f32

SLIC Loggers initialization (#870)

b2b115a

Converted SLIC's logger container and active-logger pointer to a singleton class to guard against problems with initialization. Co-authored-by: Rich Hornung <hornung1@llnl.gov>

Remove the option to skip sends if closer points have already been fo…

a3a4ed0

…und. It doesn't work in conjuction with thresholding, which is more effective.

allow downstream customers to provide their own mfem target

e84179d

remove now unnecessary sparsehash checks

0fad645

Clean up and add documentation to the new closest distance search code.

b7a1806

Begin updating doxygen comments

4f4f5a9

Improve test cases

7dc60ee

Merge remote-tracking branch 'gh/develop' into feature/gunney/distanc…

cc9d4db

…e-query-low-comm

mark that mfem was found if using the user supplied target, add mfem …

f009368

…to our export list

Merge pull request #878 from LLNL/task/white238/misc_cleanup

fc55927

Misc cleanup

Fix unintended MPI-size-dependency in object mesh set-up.

1b0eba8

Object mesh should not depend on number of MPI processes. Remove debug code.

Run reformatter.

5e4ada5

Remove old computeClosestPoints and use the new version.

b5af0bb

Merge branch 'develop' into feature/gunney/distance-query-low-comm

6485909

Remove debugging code and restore randomness in object definition.

998f8fc

Periodically check send requests instead of waiting until the end.

790d750

This helps reduce memory use by non-blocking sends.

Add additional code/tests for edge cases

267065a

bmhan12 requested review from gunney1 and agcapps August 24, 2022 16:54

bmhan12 self-assigned this Aug 24, 2022

bmhan12 mentioned this pull request Aug 24, 2022

Diffs in V 0.7.0 release candidate with respect to develop #917

Closed

kennyweiss approved these changes Aug 26, 2022

View reviewed changes

RELEASE Outdated Show resolved Hide resolved

rhornung67 reviewed Aug 26, 2022

View reviewed changes

nselliott approved these changes Aug 26, 2022

View reviewed changes

agcapps approved these changes Aug 26, 2022

View reviewed changes

update SCR link

0737fba

rhornung67 approved these changes Aug 29, 2022

View reviewed changes

white238 and others added 8 commits August 29, 2022 15:52

Merge pull request #920 from LLNL/bugfix/white238/update_scr_link

b9916f4

update SCR link

Installed Examples for Device (#919)

f30d0c8

* Add CUDA option to using-with examples, add Serac workaround for cmake example * Add HIP option to using-with examples, add -lblt_hip_runtime workaround for cmake example Co-authored-by: Chris White <white238@llnl.gov>

Update release to v0.7.0

75bdbda

Add to PR release instructions

42a0949

Order and date

ce7b567

Add emeriti

a9ef5ca

Replace contributors list in RELEASE with a link

3d486df

Date

c81eed2

bmhan12 force-pushed the v0.7.0-rc branch from b5a800e to c81eed2 Compare August 30, 2022 15:35

date formatting

551e1ea

white238 approved these changes Sep 1, 2022

View reviewed changes

bmhan12 merged commit ea51581 into main Sep 1, 2022

bmhan12 deleted the v0.7.0-rc branch September 6, 2022 18:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V0.7.0 rc #916

V0.7.0 rc #916

bmhan12 commented Aug 24, 2022 •

edited

Loading

kennyweiss left a comment

rhornung67 left a comment

bmhan12 commented Aug 30, 2022

rhornung67 commented Aug 30, 2022

kennyweiss commented Aug 30, 2022

bmhan12 commented Aug 30, 2022

white238 commented Aug 30, 2022 •

edited

Loading

rhornung67 commented Aug 30, 2022

bmhan12 commented Aug 30, 2022 •

edited

Loading

V0.7.0 rc #916

V0.7.0 rc #916

Conversation

bmhan12 commented Aug 24, 2022 • edited Loading

kennyweiss left a comment

Choose a reason for hiding this comment

rhornung67 left a comment

Choose a reason for hiding this comment

bmhan12 commented Aug 30, 2022

rhornung67 commented Aug 30, 2022

kennyweiss commented Aug 30, 2022

bmhan12 commented Aug 30, 2022

white238 commented Aug 30, 2022 • edited Loading

rhornung67 commented Aug 30, 2022

bmhan12 commented Aug 30, 2022 • edited Loading

bmhan12 commented Aug 24, 2022 •

edited

Loading

white238 commented Aug 30, 2022 •

edited

Loading

bmhan12 commented Aug 30, 2022 •

edited

Loading