Fixed IsItemDeactivatedAfterEdit() signal being broken for Checkbox()…

…, RadioButton(), Selectable(). (ocornut#8370) Item is already made inactive at the time of calling MarkItemEdited(). Fix a604d4f
LalisaTM · Feb 3, 2025 · 6265339 · 6265339
1 parent f820bf7
commit 6265339
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/docs/CHANGELOG.txt b/docs/CHANGELOG.txt
@@ -43,6 +43,9 @@ Breaking changes:
 
 Other changes:
 
+- Fixed IsItemDeactivatedAfterEdit() signal being broken for Checkbox(), Selectable(). (#8370)
+  Regression from 2025/01/13.
+
 
 -----------------------------------------------------------------------
  VERSION 1.91.8 (Released 2025-01-31)

diff --git a/imgui.cpp b/imgui.cpp
@@ -4440,8 +4440,11 @@ void ImGui::MarkItemEdited(ImGuiID id)
         return;
     if (g.ActiveId == id || g.ActiveId == 0)
     {
+        // FIXME: Can't we fully rely on LastItemData yet?
         g.ActiveIdHasBeenEditedThisFrame = true;
         g.ActiveIdHasBeenEditedBefore = true;
+        if (g.DeactivatedItemData.ID == id)
+            g.DeactivatedItemData.HasBeenEditedBefore = true;
     }
 
     // We accept a MarkItemEdited() on drag and drop targets (see https://github.com/ocornut/imgui/issues/1875#issuecomment-978243343)