refactor: unvendor typescript types definitions (#234)

Removed the vendored typescript definitions for the old versions in
favor of installing it from the package manager (`typescript-3` and
`typescript-4.7`). This should result in less code to maintain and
(hopefully) more accurate types

Author: danielpza

.prettierignore

@@ -1,2 +1 @@
-src/declarations/*
 CHANGELOG.md

package.json

@@ -61,6 +61,8 @@
     "@types/node": "^18.19.43",
     "@types/ts-expose-internals": "npm:ts-expose-internals@4.9.5",
     "@types/ts-node": "npm:ts-node@^10.9.2",
+    "@types/typescript-3": "npm:typescript@3.x",
+    "@types/typescript-4.7": "npm:typescript@4.7.x",
     "changelogen": "^0.5.5",
     "eslint": "9.x",
     "globals": "^15.9.0",

src/declarations/typescript3.d.ts

@@ -1,7 +1,8 @@
 /**
  * Changes after this point: https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes#typescript-48
  */
-import TsCurrentModule, {
+import type {
+  default as TsCurrentModule,
   AssertClause,
   ExportDeclaration,
   Expression,
@@ -13,9 +14,9 @@ import TsCurrentModule, {
   ModuleName,
   NamedExportBindings,
 } from "typescript";
-import TsFourSevenModule from "../../declarations/typescript4.7";
-import { TsTransformPathsContext } from "../../types";
-import { DownSampleTsTypes } from "../utils";
+import type TsFourSevenModule from "typescript-4.7";
+import type { TsTransformPathsContext } from "../../types";
+import type { DownSampleTsTypes } from "../utils";
 
 /* ****************************************************************************************************************** */
 // region: Mapping

src/declarations/typescript4.7.d.ts

@@ -1,7 +1,8 @@
 /**
  * Changes after this point: https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes#typescript-40
  */
-import TsCurrentModule, {
+import type {
+  default as TsCurrentModule,
   EntityName,
   ExportDeclaration,
   Expression,
@@ -18,9 +19,9 @@ import TsCurrentModule, {
   NamedImportBindings,
   TypeNode,
 } from "typescript";
-import type TsThreeEightModule from "../../declarations/typescript3";
-import { TsTransformPathsContext } from "../../types";
-import { DownSampleTsTypes } from "../utils";
+import type TsThreeEightModule from "typescript-3";
+import type { TsTransformPathsContext } from "../../types";
+import type { DownSampleTsTypes } from "../utils";
 
 /* ****************************************************************************************************************** */
 // region: Mapping
@@ -30,6 +31,7 @@ export type TypeMap = [
   [TsCurrentModule.SourceFile, TsThreeEightModule.SourceFile],
   [TsCurrentModule.StringLiteral, TsThreeEightModule.StringLiteral],
   [TsCurrentModule.CompilerOptions, TsThreeEightModule.CompilerOptions],
+  // @ts-expect-error typescript 3 doesn't export EmitResolver
   [TsCurrentModule.EmitResolver, TsThreeEightModule.EmitResolver],
   [TsCurrentModule.CallExpression, TsThreeEightModule.CallExpression],
   [TsCurrentModule.ExternalModuleReference, TsThreeEightModule.ExternalModuleReference],
@@ -74,6 +76,7 @@ export function handler(context: TsTransformPathsContext, prop: string | symbol)
         name: Identifier | undefined,
         namedBindings: NamedImportBindings | undefined,
       ) {
+        // @ts-expect-error TODO investigate type issue
         return ts.updateImportClause.apply(void 0, downSample(node, name, namedBindings));
       };
     case "updateImportDeclaration":
@@ -108,7 +111,6 @@ export function handler(context: TsTransformPathsContext, prop: string | symbol)
           dsNode.modifiers,
           dsExportClause,
           dsModuleSpecifier,
-          // @ts-expect-error - This was added in later versions of 3.x
           dsNode.isTypeOnly,
         );
       };

src/harmony/versions/four-seven.ts

@@ -302,6 +302,26 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@types/typescript-3@npm:typescript@3.x":
+  version: 3.9.10
+  resolution: "typescript@npm:3.9.10"
+  bin:
+    tsc: bin/tsc
+    tsserver: bin/tsserver
+  checksum: 10c0/863cc06070fa18a0f9c6a83265fb4922a8b51bf6f2c6760fb0b73865305ce617ea4bc6477381f9f4b7c3a8cb4a455b054f5469e6e41307733fe6a2bd9aae82f8
+  languageName: node
+  linkType: hard
+
+"@types/typescript-4.7@npm:typescript@4.7.x":
+  version: 4.7.4
+  resolution: "typescript@npm:4.7.4"
+  bin:
+    tsc: bin/tsc
+    tsserver: bin/tsserver
+  checksum: 10c0/8c1c4007b6ce5b24c49f0e89173ab9e82687cc6ae54418d1140bb63b82d6598d085ac0f993fe3d3d1fbf87a2c76f1f81d394dc76315bc72c7a9f8561c5d8d205
+  languageName: node
+  linkType: hard
+
 "@typescript-eslint/eslint-plugin@npm:8.0.1":
   version: 8.0.1
   resolution: "@typescript-eslint/eslint-plugin@npm:8.0.1"
@@ -2634,6 +2654,8 @@ __metadata:
     "@types/node": "npm:^18.19.43"
     "@types/ts-expose-internals": "npm:ts-expose-internals@4.9.5"
     "@types/ts-node": "npm:ts-node@^10.9.2"
+    "@types/typescript-3": "npm:typescript@3.x"
+    "@types/typescript-4.7": "npm:typescript@4.7.x"
     changelogen: "npm:^0.5.5"
     eslint: "npm:9.x"
     globals: "npm:^15.9.0"