Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unvendor typescript types definitions #234

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

danielpza
Copy link
Member

@danielpza danielpza commented Aug 8, 2024

Removed the vendored typescript definitions for the old versions in favor of installing it from the package manager (typescript-3 and typescript-4.7). This should result in less code to maintain and (hopefully) more accurate types

@danielpza danielpza requested a review from nonara August 8, 2024 05:38
@danielpza danielpza marked this pull request as ready for review August 8, 2024 05:38
@danielpza danielpza force-pushed the unvendor-types-definitions branch 2 times, most recently from 94c6605 to 70d9e7b Compare August 8, 2024 16:59
@danielpza danielpza force-pushed the unvendor-types-definitions branch from 70d9e7b to 1679bf6 Compare August 8, 2024 17:10
@danielpza danielpza changed the title refact: unvendor typescript types definitions refactor: unvendor typescript types definitions Aug 8, 2024
@danielpza danielpza merged commit b0dbf85 into master Aug 8, 2024
10 checks passed
@danielpza danielpza deleted the unvendor-types-definitions branch August 8, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant