Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy btn #157

Merged
merged 9 commits into from
Sep 10, 2022
Merged

Copy btn #157

merged 9 commits into from
Sep 10, 2022

Conversation

shareef-dweikat
Copy link
Contributor


OP#748

Code Review Checklist

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

@donpui
Copy link
Contributor

donpui commented Sep 7, 2022

@shareef-dweikat @ewanas should we ignore pushing pubsec.lock?
https://dart.dev/guides/libraries/private-files

@donpui donpui requested a review from ewanas September 7, 2022 06:54
@donpui
Copy link
Contributor

donpui commented Sep 8, 2022

@shareef-dweikat @ewanas should we ignore pushing pubsec.lock? https://dart.dev/guides/libraries/private-files

This is solved with another PR

@shareef-dweikat shareef-dweikat force-pushed the copy-btn branch 2 times, most recently from b41a600 to 2121779 Compare September 9, 2022 06:22
@shareef-dweikat shareef-dweikat force-pushed the copy-btn branch 2 times, most recently from 2308d01 to d509e6d Compare September 9, 2022 18:32
@shareef-dweikat shareef-dweikat merged commit 6285005 into main Sep 10, 2022
@ewanas ewanas deleted the copy-btn branch September 12, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants