Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set current version defined by version number and build number in main build file #191

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

wuan
Copy link
Contributor

@wuan wuan commented Oct 27, 2022

This should allow the downstream F-Droid build to pick up the current version numbers.

Code Review Checklist

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

Copy link
Contributor

@donpui donpui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to 1.0.1+30

@donpui
Copy link
Contributor

donpui commented Oct 28, 2022

There are some IOS related commits. Should they be here?

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
@wuan
Copy link
Contributor Author

wuan commented Oct 28, 2022

No, they are gone now.

@meejah
Copy link
Collaborator

meejah commented Oct 28, 2022

Are these versions public (like, do users see them)? It would be odd to "upgrade" from 16.0.0 to 1.0.1+30 (whatever that means). Elsewhere we talk about CalVer; does this have a "versioning scheme"?

@donpui
Copy link
Contributor

donpui commented Oct 28, 2022

This is more cleanup activity as pubspec has demo entry. Current public version is 1.0.1 (previous 1.0.0), if we are not using parameters during build, then value from pubspec will be taked. 1.0.1 is version name, 30 is version code (which in android case should be incremental number): https://developer.android.com/studio/publish/versioning

@wuan
Copy link
Contributor Author

wuan commented Oct 29, 2022

@meejah, so far we did not reflect the version number we were actually using somewhere in the configuration/code. This is what we should do and what is a requirement when deploying to F-Droid. If you look at the releases on GitHub or in our Play Store entry you will see the versions 1.0.0 and the recent update to 1.0.1.

@donpui donpui merged commit 5da3c7e into LeastAuthority:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants