Add wakelock to prevent cancelling downloads #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donpui
added a commit
that referenced
this pull request
Jan 19, 2023
* Adding iOS build changes to experment * Some changes * Update lock * Update experments * Experments * Progress * Adjusted to iOS screens * Fixing Download, Select File functions, adding icon * Added select media for iOS * Cleanup on IPA validation * Cleanup and adding stage * Small double button fix and documentation * Small fixes for button and file selector * Add push capabilities * Update flutter-intro-slider to newest commit * Added resource and debug label parameter * Update submodules and lock files * Editable config (#209) * editable config * do not use inherited preference class * expand defaults for transit relay * add cancel button and update dart_wormhole_william * improve styling * fix formatting * combine header with value and edit button. * Derive themes and use editable fields for desktop * remove Fimber logging * fix declaration of dark theme * cleanup * Improve prefs editor layout * Do not update preference when choosing default value * add widget test * also test multiple defaults * formatting * Fix Version for Targets which do not define versionCode * format * add configurable validation * Allow ws scheme * add test for Version * format * add generated mocks file * cleanup * fix preference text overflow * update dart module * fix not handling Uri parsing exceptions * trim input strings Co-authored-by: Donatas Puidokas <104410044+donpui@users.noreply.github.com> * Stage_la updated * Fix small mixtakes after merge * Added notes regarding ios and some typos fix * Ios build improvements (#219) * TEMP iOS build improvements * Saving working changes for iphonesimulator * Cleanup * Cleanup and added documentation * TEMP * Plugin update * Adding simple CI build for iOS * Adding CI build for iOS * Update plugin * fixup! Merge remote-tracking branch 'origin/main' into ios-build-improvements * fixup! Update plugin * iOS lockfile updates * Update plugin Co-authored-by: El-Hassan Wanas <wanas@leastauthority.com> * Update submodule * Revert "Update dart submodule" This reverts commit 76982bdd7d86bd981c99895b692586cd12198c15. * Update submodule * Update version to 1.0.3 * Fix styling issue * Add wakelock to keep screen on (#215) * Fix static error after update branch Co-authored-by: Andreas Würl <andi@tryb.de> Co-authored-by: El-Hassan Wanas <wanas@leastauthority.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added wakelock plugin, which prevents screen timeout during the transfer or while waiting to enter code.
Wake lock is enabled only when code is generated or entered and disabled when done or error cases.
This was added, after I jumped on issue, when on iOS device, transfers gets cancelled, after phone screens turn off, which by default 30sec - 1 min. This prevents bigger files sending (or when you have slow network) and you have manually set always on screen in order to send something.
I have not seen issue on Android phone, however there are many version of Android phone manufactures, I guess this can also be issue for Android too in some cases. Not sure if we need this for Desktop version as during testing, I have not jumped on such issues.
Manually tested with iOS and Android.
Code Review Checklist