Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved E2E tests and enabled in CI #50

Merged
merged 77 commits into from
Nov 1, 2022
Merged

Improved E2E tests and enabled in CI #50

merged 77 commits into from
Nov 1, 2022
+905 −918

Conversation

donpui
Copy link
Contributor

@donpui donpui commented Oct 3, 2022

Updated E2E tests:

  • updated to match current functionality
  • included static page tests
  • add few tests for placeholders till bugs will be solved
  • add few test identifiers

Enabled to run in CI:

  • updated Dockerfiles to have latest versions
  • optimised docker composer to run faster
  • removed redundant actions
  • separated client to client-ci to run on CI as there are some issues with volumes running on Github actions.
  • switched transit-relay and mailbox used to use docker hub images (saves some time to build)

Donatas Puidokas added 30 commits September 8, 2022 21:50
test workflow

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
7d7c459
adding E2E tests to CI
5258783
change to 1 instance
35032f5
adding html reporter
dac26d9
small WDIO fix
41c3b67
small fix
740f0ea
Adding artifacts
12fcd25
Fix workflow and change tests
105a035
one more fix
c73d518
reports fix
e918509
fix
3dc291c
fix
dd0f5f9
fix
9e72103
test fix
452e34b
one more fix
0b976af
trying to fix
d51e7cc
trying to fix
f166133
stil fix
0e98976
Fix
7a4cbce
attempt to fix
0edab47
attempt to fix
e5afdcd
attempt to fix
941a621
attempt to fix
b282a19
cleanup report gen
e46d455
additional fixes
980d89c
few fixes
e576178
few more fix
c23bbb7
Add e2e tests on CI
a1dfa94
E2E only on pull requests
2de94b8
test adjustment
88cd657
@donpui donpui requested a review from JustusFT October 3, 2022 15:03
JustusFT
JustusFT requested changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@JustusFT JustusFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍, here's some feedback

@donpui donpui requested a review from JustusFT October 10, 2022 12:41
JustusFT
JustusFT requested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@JustusFT JustusFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need a few more changes to get the dev environment running, then we should be good to go 👍

donpui and others added 2 commits October 13, 2022 13:48
@donpui @JustusFT
Update client/gulpfile.js
04046fc 
Co-authored-by: Justus Tumacder <JustusFT@gmail.com>
@donpui
Fixed watch and dir for E2E (#4)
9afddcb
@donpui donpui requested a review from JustusFT October 14, 2022 06:04
JustusFT
JustusFT approved these changes Nov 1, 2022
View reviewed changes
Copy link
Contributor

@JustusFT JustusFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JustusFT JustusFT merged commit a4f8cf9 into LeastAuthority:main Nov 1, 2022
@donpui donpui deleted the ci-e2e-update branch January 26, 2023 07:49
@JustusFT JustusFT mentioned this pull request Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meejah meejah

@JustusFT JustusFT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@donpui @meejah @JustusFT