Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new TI devices #21

Closed
wants to merge 0 commits into from
Closed

Added new TI devices #21

wants to merge 0 commits into from

Conversation

eto-
Copy link
Contributor

@eto- eto- commented Jan 12, 2025

SUMMARY

Added new TI devices with dependencies.

DATASHEETS / REFERENCES

All the links are in the datasheet field of the corresponding devices

OPEN QUESTIONS / UNRESOLVED ISSUES
  • The quality of the step files may be improved.
  • The legend for high density packages is complicated
  • The WSON are nonstandard packages from TI, therefore I added them here.
  • The WQFN10 is more standard and it could go in Base library but it would be better to have a script generating them
    Symbols and Components can be moved elsewhere if needed.
CHECKLIST
  • [x ] I have read and followed the library conventions¹.
  • For packages, I followed IPC7351C (see details in library conventions).
  • For modified elements, I bumped their version number².
  • [x ] I already used the new library elements in a design and verified their correctness (optional).
  • [x ] I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
  • [x ] I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

@ubruhin ubruhin added addition New library element. ready for review Waiting for review by maintainers. labels Jan 12, 2025
@eto-
Copy link
Contributor Author

eto- commented Jan 23, 2025

Updates?

@ubruhin
Copy link
Contributor

ubruhin commented Jan 24, 2025

Huh that's a lot to review 🙈

Would you mind splitting this into separate PRs? For the start, a PR adding only the devices which don't need new dependencies would be nice - they are straight-forward to review so we can get them merged fast. Then we can do the rest step by step.

Btw, thanks for using the new feature of adding datasheet URLs, it is very useful for the review process 😃

@eto-
Copy link
Contributor Author

eto- commented Jan 26, 2025

How do you prefer me to proceed?

I can unwind my commit and split the PRs between:

  • the simple devices that I added
  • the wson devices
  • the wqfn10 devices

Let me know

@ubruhin
Copy link
Contributor

ubruhin commented Jan 27, 2025

I can unwind my commit and split the PRs between:

Yes that's what I meant in my comment above. You could also just move the simple devices to a separate branch and open a PR for it and we pick up the rest later. Up to you.

For the new packages we'll have to decide anyway how to proceed with them (base library or not, generator or not).

@eto-
Copy link
Contributor Author

eto- commented Feb 3, 2025

I created the branch for simple devices and started a new PR.

The packages are 2 types:

  • wson are TI specific, I do not think it is worth to have generator
  • WQFN are generic and there is a generator script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New library element. ready for review Waiting for review by maintainers.
Development

Successfully merging this pull request may close these issues.

2 participants