Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft for build and publish to npm #5

Merged
merged 16 commits into from
Dec 6, 2024
Merged

draft for build and publish to npm #5

merged 16 commits into from
Dec 6, 2024

Conversation

jdsika
Copy link
Contributor

@jdsika jdsika commented Nov 27, 2024

resolves #6

Todos

  • Check build with yarn
  • Check if linting is needed
  • Remove pre-build files from repository
  • build and deploy on release to NPM
  • Adapt readme to explain installation, test locally and the versioning on release

Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
@jdsika jdsika mentioned this pull request Nov 27, 2024
Closed
@jdsika jdsika marked this pull request as ready for review December 6, 2024 07:27
@jdsika jdsika requested a review from rmessaou as a code owner December 6, 2024 07:27
* Update actions to latest versions

Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
package.json Outdated
"devDependencies": {
"@bufbuild/buf": "^1.45.0",
"@bufbuild/protobuf": "^2.2.0",
"@bufbuild/protoc-gen-es": "^2.2.0",
"@eslint/js": "^9.16.0",
"eslint": "^9.16.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is that here a specific config for eslint that we shall use across all repos in this organization? https://github.com/Lichtblick-Suite/eslint-plugin

Copy link
Contributor

@samikachai samikachai Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting now follows the lichtblick standards, one thing to note however, @typescript-eslint does not support typescript v5.7.2, it only supports versions >=v4.3.5 <v5.3.0.

Everything seems to work fine, but we get the following warning when linting:

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.3.0

YOUR TYPESCRIPT VERSION: 5.7.2

Please only submit bug reports when using the officially supported version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just use 5.3 in this repo? Or accept the warning?

@jdsika jdsika added the enhancement New feature or request label Dec 6, 2024
@jdsika
Copy link
Contributor Author

jdsika commented Dec 6, 2024

README needs to be adapted accordingly. Afterwards I will merge, check if the pipeline is green and then try the release tag v0.1.0

@samikachai samikachai self-requested a review December 6, 2024 15:04
Copy link
Contributor Author

@jdsika jdsika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it :)

@jdsika jdsika merged commit 763b3d8 into main Dec 6, 2024
1 check passed
@jdsika jdsika deleted the ci/build-and-deploy branch December 6, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TODOs
3 participants