-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft for build and publish to npm #5
Conversation
Signed-off-by: jdsika <carlo.van-driesten@bmw.de>
…age.json with it.
* Update actions to latest versions Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
package.json
Outdated
"devDependencies": { | ||
"@bufbuild/buf": "^1.45.0", | ||
"@bufbuild/protobuf": "^2.2.0", | ||
"@bufbuild/protoc-gen-es": "^2.2.0", | ||
"@eslint/js": "^9.16.0", | ||
"eslint": "^9.16.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: is that here a specific config for eslint that we shall use across all repos in this organization? https://github.com/Lichtblick-Suite/eslint-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting now follows the lichtblick standards, one thing to note however, @typescript-eslint does not support typescript v5.7.2, it only supports versions >=v4.3.5 <v5.3.0.
Everything seems to work fine, but we get the following warning when linting:
WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.
You may find that it works just fine, or you may not.
SUPPORTED TYPESCRIPT VERSIONS: >=4.3.5 <5.3.0
YOUR TYPESCRIPT VERSION: 5.7.2
Please only submit bug reports when using the officially supported version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just use 5.3 in this repo? Or accept the warning?
README needs to be adapted accordingly. Afterwards I will merge, check if the pipeline is green and then try the release tag v0.1.0 |
…uite/asam-osi-types into ci/build-and-deploy
…s | Add format script using prettier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try it :)
resolves #6
Todos