Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean main.nf #65

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Clean main.nf #65

merged 3 commits into from
Aug 19, 2024

Conversation

jylee-bcm
Copy link
Contributor

@jylee-bcm jylee-bcm commented Aug 19, 2024 •
edited
Loading

I would like to clean a little bit about the main.nf.

  • Separate functions from processes
  • Use named outputs

Feel free to feedback the changes!

@jylee-bcm jylee-bcm self-assigned this Aug 19, 2024
@jylee-bcm jylee-bcm added the enhancement New feature or request label Aug 19, 2024
@jylee-bcm jylee-bcm changed the title Use function naming rule for functions in workflow file Clean main.wf Aug 19, 2024
@hyunhwan-bcm hyunhwan-bcm changed the title Clean main.wf Clean main.nf Aug 19, 2024
@ZaahidShaik
Copy link
Contributor

Can you run these cmd's and add the output in the PR details section. To verify you changes.

  1. Checking help.
nextflow run main.nf --help
  1. Checking the error are working fine. Just give the same VCF file path as input in both --input-vcf & --input-hpo or any non '.txt' / 'hpo' files. You should get these errors.
Error: '--input_hpo' value '/home/sample/sample.vcf.gz' should be an HPO file (.hpo) or (.txt)

  To see usage and available parameters run `nextflow run main.nf --help`

@ZaahidShaik
Copy link
Contributor

Verified in person with @jylee-bcm, Approving!

@jylee-bcm jylee-bcm marked this pull request as ready for review August 19, 2024 22:09
@hyunhwan-bcm hyunhwan-bcm merged commit 0ce4a36 into nextflow_conversion Aug 19, 2024
0 of 2 checks passed
@jylee-bcm
Copy link
Contributor Author

@ZaahidShaik @hyunhwan-bcm Thank you for reviewing, but I added one thing more regarding named output. I would like to get your approval once again!

@jylee-bcm
Copy link
Contributor Author

Oh! haha.. already merged. Thanks!

@jylee-bcm jylee-bcm mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZaahidShaik ZaahidShaik ZaahidShaik approved these changes

@hyunhwan-bcm hyunhwan-bcm hyunhwan-bcm approved these changes

Assignees

@jylee-bcm jylee-bcm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jylee-bcm @ZaahidShaik @hyunhwan-bcm