Add run as admin suggestion for Windows #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you are running Discord as administrator, NSO-RPC will fail to connect to the discord IPC pipe due to windows permissions.
I attempted to catch the
'[WinError 5] Access is denied'
exception at client/cli.py#L50-L56, as it returns an IOError exception, however I had multiple timing and scope(?) issues around that, even trying to add handler and extra stuff around a simple boolean had consistency issues, reporting not connected to discord, then afterwards saying we are fine etc.This solution's main issue is that its assuming on windows, the only reason for NSO-RPC to have issues connecting to discord is because Discord is running with Admin privileges.
Note: This will give a false positive telling the user to try running NSO-RPC with Admin if Discord is not running.