Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to qtpy/Qt6 #79

Merged
merged 1 commit into from
May 31, 2023
Merged

Port to qtpy/Qt6 #79

merged 1 commit into from
May 31, 2023

Conversation

HotaruBlaze
Copy link
Contributor

This PR has already been talked about a fair bit in discord, So I'll just go over the basics.

There isn't too much of a point to update this other than convenience and that Qt5 is pretty old and reached EoS (End of Support) a couple of days ago.

  1. We are using our own fork of python-qtwidgets, This is due to the poor maintainer activity on the repo, as well as issues around the QtPy port they did, that I've had to fix to allow Qt5 and Qt6 Support. If security is a concern, I'd recommend forking my fork of python-qtwidgets and updating requirements.txt.
  2. By default everything is now being built assuming Qt6 is the default, This shouldn't actually be an issue, and we can provide Qt5 Specific builds the need to comes up, as its mostly a couple of extra lines and job in GitHub Actions.
  3. client/layout/__init__.py got split into two different Qt versions, client/layout/qt5_layout.py and client/layout/qt6_layout.py
  4. PyQt5/PyQt6 has been removed from requirements.txt, if you want to build for a specific Qt, you should only have one of those installed, GitHub Actions and the ubuntu install script will default to installing PyQt6.

Note: You can have both PyQt5 and PyQt6 pip packages installed at the same time, however it will currently default to PyQt5 unless you provide it with an argument variable when launching app.py directly. (the bundled app will use whatever Qt it was built for)

@HotaruBlaze HotaruBlaze changed the base branch from main to development May 31, 2023 11:52
@MCMi460
Copy link
Owner

MCMi460 commented May 31, 2023

This is very epic. Thank you for doing this! It had to have been a heck of a monumental project.

@MCMi460 MCMi460 merged commit d25f56a into MCMi460:development May 31, 2023
@HotaruBlaze HotaruBlaze deleted the qt6-port branch April 29, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants