Stop exposing ros-master port and better health check #148

MithunKinarullathil · 2022-05-12T12:54:06Z

Remove exposed 11311, as it is currently stoping user from running roscore outside and since we don't have access to the topics in the host (yet), this is a pain
Better healthcheck for roscore container
Fixes: Not able to run my own ros beside movai-flow, and there are no topics exposed as well #151
https://movai.atlassian.net/browse/RP-1413

@xsoulp FYI. This should solve a bit of the issue you were mentioning.
@diasdm This should be enough for the sonarqube test?

Make sure you are opening from a topic/feature/bugfix branch
Ensure that the PR title represents the desired changes
Ensure that the PR description detail the desired changes
Link to relevant issues in GitHub or Jira
Link to relevant pull requests, esp. upstream and downstream changes
Ensure you have provided tests - that demonstrates feature works or fixes the issue

…ore outside Better healthcheck for roscore container

guide-bot · 2022-05-12T12:54:10Z

Thanks for opening this Pull Request!
We need you to:

Complete the activities.

Action: Complete Link to relevant issues in GitHub or Jira
Action: Complete Link to relevant pull requests, esp. upstream and downstream changes
Action: Complete Ensure you have provided tests - that demonstrates feature works or fixes the issue

If an activity is not applicable, use '~activity description~' to mark it not applicable.

AlexFernandes-MOVAI

Can you please indicate the use cases list you want to achieve with this PR ?

better health check is one thing internal to the container : no problem to enhance it
not exposing the port of ros-master is something more functional and feature oriented, I am afraid this change is not enough to reach the aimed feature

MithunKinarullathil · 2022-05-12T14:13:09Z

This PR is just to close up a wound that is restricting the users without additional advantage. We have another good way to expose the ROS topics using the movai-cheatsheet, which has been tested thoroughly in the EE. It is better than exposing the full network to the host (which can have unintended consequences). So to summarize what this PR archives.

User is able to run their own ROS launches and ROS things in their host independently with movi-flow running beside it. (currently, this is not possible if movai-flow is running, which is restricting function without providing additional value)
For the short term we will document the steps from the cheat sheet, and how to expose topics manually to the community
For the long term, once the cheatsheet tools are exposed, they will be able to do this easily using the cli.

AlexFernandes-MOVAI · 2022-05-12T14:50:34Z

This PR is just to close up a wound that is restricting the users without additional advantage. We have another good way to expose the ROS topics using the movai-cheatsheet, which has been tested thoroughly in the EE. It is better than exposing the full network to the host (which can have unintended consequences). So to summarize what this PR archives.

User is able to run their own ROS launches and ROS things in their host independently with movi-flow running beside it. (currently, this is not possible if movai-flow is running, which is restricting function without providing additional value)

For the short term we will document the steps from the cheat sheet, and how to expose topics manually to the community

For the long term, once the cheatsheet tools are exposed, they will be able to do this easily using the cli.

OK, I got it. I will just complete that for the long term, I would recommend not to have any CLI at all ;)

MithunKinarullathil · 2022-05-12T15:02:29Z

This PR is just to close up a wound that is restricting the users without additional advantage. We have another good way to expose the ROS topics using the movai-cheatsheet, which has been tested thoroughly in the EE. It is better than exposing the full network to the host (which can have unintended consequences). So to summarize what this PR archives.

User is able to run their own ROS launches and ROS things in their host independently with movi-flow running beside it. (currently, this is not possible if movai-flow is running, which is restricting function without providing additional value)

For the short term we will document the steps from the cheat sheet, and how to expose topics manually to the community

For the long term, once the cheatsheet tools are exposed, they will be able to do this easily using the cli.

OK, I got it. I will just complete that for the long term, I would recommend not to have any CLI at all ;)

Haha. I have to disagree from a ros developer perspective. It's much easier for me to develop with a cli even if there is a good UI tool. It saves time ;)