Fix scroll bar and alt+tab issues in SplitButton's popup #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Deadpikle Tabbing out from the control doesn't work. |
|
@punker76 Whoops; didn't realize that was a thing. Just to make sure I know what you're saying & wanting, here's what I've got working now. You can now click the dropdown, scroll a bit, and then hit 'tab' to close the popup at any time. Should be able to hit 'enter' while the dropdown is focused then hit 'tab' to close it again. Alt+Tab, the scroll bar, etc. all still appear to be working. (I guess the .gif is kinda silly since it doesn't show keystrokes...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Reverts/alters #2575 to fix #2574 in a way that doesn't entirely break the scroll bar. #2575 broke clicking on the scroll bar within the
SplitButton Popup. My previous "fix" for my fix ( #2616 ) just created different issues*. Hopefully I've actually gotten the thing fully working this time and not caused more issues (>_<; sorry about that...).*In my work project, #2616 could cause my entire window to not respond to mouse events after I closed the
SplitButton Popupuntil I moused off and on the window again. It was really weird.