Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sovol config Updates #804

Merged
merged 19 commits into from
Sep 30, 2022
Merged

Conversation

ils15
Copy link
Contributor

@ils15 ils15 commented Aug 21, 2022

Update Configuration for Sovol Printers

Insert easy coment line to enable/disable 3D touch

ils15 added 2 commits August 21, 2022 13:47
Update Configuration for Sovol Printers

Insert easy coment line to enable/disable 3D touch
Copy link

@Farva42 Farva42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original Board addition is not needed as this is covered by the CrealityV22 & CrealityV221 configs. It also looks like you are using an older config file ie 2.0.9.2 vs the current 2.1.x which will cause issues on the existing configs but a current 2.1.x for the new examples.

@ils15
Copy link
Contributor Author

ils15 commented Aug 22, 2022

My mistake
I thinked v22 is a silent board
I will update v22 and v221 boards to match with new settings
Thanks

@Farva42
Copy link

Farva42 commented Aug 22, 2022

V22 is the stock board with A4988 drivers. V221 is the silent board with TMC2208_STANDALONE.

Fixed Duplicated Files for V22 = Original Board
Updated V221 with new settings
@ils15
Copy link
Contributor Author

ils15 commented Aug 22, 2022

V22 is the stock board with A4988 drivers. V221 is the silent board with TMC2208_STANDALONE.

Great
Now i'm updated things here
thanks

Copy link
Contributor Author

@ils15 ils15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update with Z Probe Offset and Babystepping Combined

Copy link
Contributor Author

@ils15 ils15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parametrize SV01 BTT SKR Mini E3 V3

@thinkyhead thinkyhead force-pushed the import-2.1.x branch 8 times, most recently from 884c20f to 828c1da Compare August 26, 2022 03:08
//#define LCD_LANGUAGE_2 fr
//#define LCD_LANGUAGE_3 de
#define LCD_LANGUAGE_2 pt_br
#define LCD_LANGUAGE_3 es
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit too personalized.

@thinkyhead thinkyhead force-pushed the import-2.1.x branch 2 times, most recently from a249a09 to 6067e9b Compare August 26, 2022 03:21
@thinkyhead
Copy link
Member

I put in the necessary time to clean up and update this stunning submission.
Please review the commits for changes and verify that nothing got lost in the cleanup.

Copy link
Contributor Author

@ils15 ils15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be fine
Thanks @thinkyhead

@thinkyhead
Copy link
Member

Okay, then. I went ahead and corrected the various extant errors, regressions, and outdated options, bringing this into better parity with the development tree bugfix-2.1.x. This ought to be reviewed by some other SOVOL users before it is merged, since it contains many personally tailored preferences that may not be embraced by other users.

@thinkyhead thinkyhead merged commit 2956793 into MarlinFirmware:import-2.1.x Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants