Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard methods to wait for heating #11949

Merged

Conversation

thinkyhead
Copy link
Member

As noted in #11876

Problem: Normal hot-end heating with M109 waits for the temperature to stabilize, but reheating —as used with the pause for filament change function— only waits for the temperature to intersect the target temperature hysteresis. As a result, when resuming a print the temperature may overshoot and fall below target even as the print continues.

Solution: Break out the code from M109 / M190 that waits for hotend / bed heating and move these heating loops to the Temperature class. Then, use the wait_for_hotend method instead of wait_for_heating when resuming after a filament change.

  • The wait_for_bed method isn't used outside of M190 but it may come in handy later.

@thinkyhead thinkyhead force-pushed the bf2_standardized_heating branch 3 times, most recently from 188672c to 4c9763e Compare September 29, 2018 01:10
@thinkyhead thinkyhead force-pushed the bf2_standardized_heating branch from 4c9763e to df1e9e0 Compare September 29, 2018 01:11
@thinkyhead thinkyhead merged commit e4389f7 into MarlinFirmware:bugfix-2.0.x Sep 29, 2018
@thinkyhead thinkyhead deleted the bf2_standardized_heating branch September 29, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant