Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Due to the fix for #1248, X and Y probe offsets must not be floats. #1282

Merged
merged 1 commit into from
Jan 2, 2015

Conversation

vandarin
Copy link
Contributor

The compiler does not support comparing float values: "error: floating constant in preprocessor expression"
The loss in X/Y precision won't matter for Z probes, as most microswitches or inductive sensors are larger than 1mm square anyway.

…t be floats.

The compiler does not support comparing float values: "error: floating constant in preprocessor expression"
The loss in X/Y precision shouldn't matter for Z probes, as most microswitches or inductive sensors are larger than 1mm square anyway.
@a0s
Copy link

a0s commented Jan 2, 2015

This is not fix for problem, only trying to mask it :)

@vandarin
Copy link
Contributor Author

vandarin commented Jan 2, 2015

Agreed, it's not a true fix, but the sanity check @alexborro added is a good thing and we should give people a clue that floats won't work for the offsets.

@alexborro
Copy link
Contributor

Why not work?? It used to work so far...

2015-01-02 11:15 GMT-02:00 Lane Roberts notifications@github.com:

Agreed, it's not a true fix, but the sanity check @alexborro
https://github.com/alexborro added is a good thing and we should give
people a clue that floats won't work for the offsets.


Reply to this email directly or view it on GitHub
https://github.com/ErikZalm/Marlin/pull/1282#issuecomment-68525752.

"Não é o mais forte da espécie que sobrevive, nem o mais inteligente. É
aquele que se adapta melhor as mudanças" ( Charles Darwin )

Alex Borro

boelle added a commit that referenced this pull request Jan 2, 2015
Due to the fix for #1248, X and Y probe offsets must not be floats.
@boelle boelle merged commit 63da690 into MarlinFirmware:Development Jan 2, 2015
@nophead
Copy link
Contributor

nophead commented Jan 2, 2015

@alexborro,
The reason was given by @vandarin. The constants are used in a #if statement and the C preprocessor does not allow floating point constants to be compared, only integers. I don't know how it could have worked before unless the #if is a recent addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants