Return 'false' on EEPROM connection fail #14776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description
With FYSETC Cheetah board, EEPROM file doesn't get loaded when booting.
After debugging with SWD probe, I found the
first_load
function setsloaded=true
no matter of the access return, avoiding to properly load EEPROM file when SD got detected.Without this fix, here is the console output:
With that fix:
IDK if that's the right approach to fix it, but it's the simpler one I found to avoid extra pre-compiler conditions and make it a general improvement.