Use E in M306 T to specify autotuned extruder #25326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMagician
force-pushed
the
add_e_to_m306_autotune
branch
2 times, most recently
from
8a426b4 to
f14988c
Compare
GMagician
commented
Feb 1, 2023
Marlin/src/module/temperature.cpp
Outdated
| @@ -914,27 +914,29 @@ volatile bool Temperature::raw_temps_ready = false; | |||
| }; | |||
|
|
|||
| struct OnExit { | |||
| heater_id_t e; | |||
There was a problem hiding this comment.
Not sure OnExit local variable is right approach
There was a problem hiding this comment.
Not type has been changed to uint8_t but question is still valid
Let MPC autotune to specify extruder
Use uint8_t instead of heater_id_t because active_extruder (original variable) was such type
1 task
|
|
|
IMO when bed will be implemented it may be renamed to heater_id, but I'm ready to change it now if you think it's better |
thinkyhead
force-pushed
the
bugfix-2.1.x
branch
from
40e1292 to
339773d
Compare
thinkyhead
added a commit
to MarlinFirmware/MarlinDocumentation
that referenced
this pull request
Feb 12, 2023
This can wait. I'll go ahead and merge what we have now. |
thinkyhead
added a commit
to MarlinFirmware/MarlinDocumentation
that referenced
this pull request
Feb 12, 2023
thinkyhead
force-pushed
the
add_e_to_m306_autotune
branch
from
503ebc5 to
cac0148
Compare
thinkyhead
added a commit
that referenced
this pull request
Feb 12, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
deveth0
pushed a commit
to deveth0/Bigtree-SKR-Mini-v3-Ender3v2-Marlin
that referenced
this pull request
Feb 12, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
Feb 22, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
LMBernardo
pushed a commit
to LMBernardo/Marlin
that referenced
this pull request
Mar 19, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
that referenced
this pull request
Apr 7, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
Apr 8, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
that referenced
this pull request
Apr 10, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
thinkyhead
added a commit
to thinkyhead/Marlin
that referenced
this pull request
May 16, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 17, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
tspiva
pushed a commit
to tspiva/Marlin
that referenced
this pull request
May 25, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 9, 2023
Co-Authored-By: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let MPC autotune to specify extruder
It should implement #25325 but I can't test it.