Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange logo options #25684

Merged

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Apr 15, 2023

Description

adds the option to choose a small static Marlin logo, large animated, or both enabled = a small animated logo
(as per src/lcd/dogm/dogm_Bootscreen.h)

added a line between two env: in stm32f4.ini

Requirements

Benefits

helps gives user the options and clarifies what it does.

wording and layout may be considered for change

Configurations

Related Issues

@thinkyhead thinkyhead changed the title rearrange Marling Logo options Rearrange logo options Apr 16, 2023
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x-working branch from 7564cc9 to 3bce192 Compare April 16, 2023 01:48
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x-working branch from 3bce192 to e3cd406 Compare April 16, 2023 01:50
@thinkyhead thinkyhead merged commit 883bde0 into MarlinFirmware:bugfix-2.1.x Apr 16, 2023
thinkyhead added a commit to MarlinFirmware/Configurations that referenced this pull request Apr 16, 2023
Copy link
Contributor Author

@classicrocker883 classicrocker883 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  #if ANY(HAS_MARLINUI_U8GLIB, TOUCH_UI_FTDI_EVE, IS_DWIN_MARLINUI)
    #define SHOW_BOOTSCREEN                 // Show the Marlin bootscreen on startup. ** ENABLE FOR PRODUCTION **
    #if ENABLED(SHOW_BOOTSCREEN)
      //#define SHOW_CUSTOM_BOOTSCREEN      // Show the bitmap in Marlin/_Bootscreen.h on startup.
      #define BOOTSCREEN_TIMEOUT 4000       // (ms) Total Duration to display the boot screen(s)
      #if EITHER(HAS_MARLINUI_U8GLIB, TFT_COLOR_UI)
        #define BOOT_MARLIN_LOGO_SMALL      // Show a smaller Marlin logo on the Boot Screen (saving lots of flash)
      #endif
    #endif

would moving SHOW_CUSTOM_BOOTSCREEN be better moved up like so, or no?

@classicrocker883 classicrocker883 deleted the bugfix-2.1.x-working branch April 17, 2023 18:42
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 8, 2023
EvilGremlin pushed a commit to EvilGremlin/Marlin that referenced this pull request May 17, 2023
tspiva pushed a commit to tspiva/Marlin that referenced this pull request May 25, 2023
Andy-Big pushed a commit to Andy-Big/Marlin_FB_Reborn that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants