-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange logo options #25684
Merged
thinkyhead
merged 3 commits into
MarlinFirmware:bugfix-2.1.x
from
classicrocker883:bugfix-2.1.x-working
Apr 16, 2023
Merged
Rearrange logo options #25684
thinkyhead
merged 3 commits into
MarlinFirmware:bugfix-2.1.x
from
classicrocker883:bugfix-2.1.x-working
Apr 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7564cc9
to
3bce192
Compare
3bce192
to
e3cd406
Compare
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Apr 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#if ANY(HAS_MARLINUI_U8GLIB, TOUCH_UI_FTDI_EVE, IS_DWIN_MARLINUI)
#define SHOW_BOOTSCREEN // Show the Marlin bootscreen on startup. ** ENABLE FOR PRODUCTION **
#if ENABLED(SHOW_BOOTSCREEN)
//#define SHOW_CUSTOM_BOOTSCREEN // Show the bitmap in Marlin/_Bootscreen.h on startup.
#define BOOTSCREEN_TIMEOUT 4000 // (ms) Total Duration to display the boot screen(s)
#if EITHER(HAS_MARLINUI_U8GLIB, TFT_COLOR_UI)
#define BOOT_MARLIN_LOGO_SMALL // Show a smaller Marlin logo on the Boot Screen (saving lots of flash)
#endif
#endif
would moving SHOW_CUSTOM_BOOTSCREEN
be better moved up like so, or no?
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 8, 2023
EvilGremlin
pushed a commit
to EvilGremlin/Marlin
that referenced
this pull request
May 17, 2023
tspiva
pushed a commit
to tspiva/Marlin
that referenced
this pull request
May 25, 2023
Andy-Big
pushed a commit
to Andy-Big/Marlin_FB_Reborn
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds the option to choose a small static Marlin logo, large animated, or both enabled = a small animated logo
(as per src/lcd/dogm/dogm_Bootscreen.h)
added a line between two
env:
in stm32f4.iniRequirements
Benefits
helps gives user the options and clarifies what it does.
wording and layout may be considered for change
Configurations
Related Issues