-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detailed build version #2577
Detailed build version #2577
Conversation
The long descriptor will still be available in M115
Maybe is easier to handle if we have to strings. |
I was thinking that you would either use the short form (like on an LCD) or the long form as in M115. The generation of the long form comes from Currently, from That will allow me to generate things like "1.1 RC2-g1234567" easily. On Unix-based machines, I have plenty of ways to parse and reformat however we wish. Also, do we want ANY spaces in the version? (I don't know, or particularly care) |
Until new i hafe seen it from the othe side. Concatenating strings in the pree processor is an easy task- splitting seems to be impossible. |
I guess that it really depends on what "tools" we can assume/require on any platform. For example, Tim, not wanting to use the Arduino IDE, is accustomed to having a Makefile. But, I return to my question. Do you really have a use case where you need the long version broken into pieces (rather than using the short version)? I worry about fragmenting the long version because that only encourages someone to muck with it and leave part of it out in just the place we want it most. (M115, etc.) |
No i have not a real reason. I just realized that i made the bootscreen for 20*4 displays in the assumption the version-string would fit on the right side of the logo. Than i thought it could fit in two lines. But it could easily work like in the 16x4 version - as s sequence of the URL, the version and what ever we want, scrolling if to long. |
What about displaying the short version on the splash screen. Then add an "About" menu item on all display types that gives the full information. Something like that? I know it would take up more code space to do something like that though. |
Personally, I don't think that you need to show the long version on the screen. The short version should be sufficient. Where the long version comes into play is when we need to ask someone "EXACTLY what version are you using?" or stated as "What is the output of M115?" From that, we will know the version that they are using. Much better than hearing "the development branch from 2 days ago" |
Moved to MarlinDev #7 |
M115 provides the detailed version number (which includes the git commit SHA).
However, this is too long to be displayed on LCD displays, etc.
Therefore, I have created both the long version and a shorter one.
define SHORT_BUILD_VERSION "1.1 dev"
define DETAILED_BUILD_VERSION "1.1 dev-151-g3746552"
Also, since the use of automatic versioning is, at the present time, an optional feature, the command line build flag is now changed from HAS_AUTOMATIC_VERSIONING to USE_AUTOMATIC_VERSIONING