-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anycubic Vyper - compile fix, home screen temperature update, power fail display fix #26261
Anycubic Vyper - compile fix, home screen temperature update, power fail display fix #26261
Conversation
The more I think about it the more I wonder why the original software turned the backlight off if power loss recovery was enabled. I just don't see a scenario where this is helpful. Maybe the better approach is to disable turnng off the LCD. |
I've pushed a commit that disables power fail recovery from turning off the LCD's backlight. I just don't see a situation where turning off the LCD and requiring a reboot/reset to recover is a good thing. |
It looks like you intended to use |
c624e13
to
e6f1b07
Compare
9c65146
to
4f65466
Compare
Stock Vyper config compiles fine now, so I don't know if this is still needed. There's still an issue with temperatures not displaying according to the user I'm helping on Discord today, so those changes are still needed. One issue that has come up several times on Discord is the firmware name. The current format of The second reported issue is the Z axis not working, but I don't have more information on that at the moment. |
Hi Concerning the temperature display problem on the main screen, I was about to do a PR with this commit eb9f48df0c57b900dd0ea0f66a2af9ba6264427e when I saw this PR here. I think my fix is more correct because updating TXT_PREHEAT in page 1 handler does not make sense. But my fix do not include the part for brightness. Let me know if do a PR with this commit. |
This PR broke our Ender-3 S1 Plus and Ender-3 S1 Pro configs / likely any config with |
Partially reverts change from MarlinFirmware#26261
This PR addresses three items:
'class Anycubic::DgusTFT' has no member named 'language'
Solutions:
1 - compile error
Because of the way
ui_language
is declared it can't just be used as a replacement forlanguage
within the UI.language
to the class Anycubic::DgusTFT.DgusTFT::set_language
,DgusTFT::toggle_language
andDGUSRxHandler::setLanguage
so that bothui_language
andlanguage
are updated at the same time.2 - home screen: bed and heater updates
Added code to the function
DgusTFT::idleLoop
so that the bed and heater text area are updated when the english and chinese home screens are active.3 - LCD's backlight turned off after pressing reset button or power up
Restoring the EEPROM eventually calls
DgusTFT::powerLoss
which turns off the LCD's backlight.Added code to the function
DgusTFT::idleLoop
so that the LCD's backlight is turned on when the english and chinese home screens are active.Testing
Hardware:
Motherboard: BTT SKR-PRO V1.1
LCD: DMG80480C043_02WTC
Software:
Latest bugfix-2.1.x
Starting configuration: bugfix-2.1.x/config/examples/AnyCubic/Vyper
Changes to configuration:
LCD firmware: downloaded from example config noted above
NOTE - Vyper display ZWLF043_001 won't talk on the serial port when uploaded with the DWIN set from the example config. The same SD card was used to upload both the ZWLF043_001 and the DMG80480C043_02WTC. The DMG80480C043_02WTC is fully functional but the ZWLF043_001 just goes through the power up graphics and then freezes with the Anycubic symbol being displayed. Either different DWIN sets are needed or I have a defective ZWLF043_001.