Add EDITABLE_HOMING_FEEDRATE menu to ProUI #27469
Merged
+134
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the new
EDITABLE_HOMING_FEEDRATE
, this adds a menu option to ProUI to edit the homing feedrates.hmiValue.axis = X_AXIS, set___
=>hmiValue.axis = X_AXIS; set___
example:
Requirements
Benefits
Configurations
Related Issues
One thing I would like changed - that I just can't figure out - is changing the homing feedrate from float to int because these values are in the thousands, if a user wants to change them through the UI, using a scroll may take much too long because of the precision in decimal place.
So if Homing is 3600.0, it takes many scrolls for a significant change, so changing this to an int simplifies things.
However it isn't as simple as changing
setPFloatOnClick
tosetPIntOnClick
, oronDrawPFloatMenu
toonDrawPIntMenu
.I tried this and it breaks using it entirely.I'm not sure the way to go about this so would be great for some help figuring this out.This issue should be fixed now, added an intermittent value and
static_cast
as anint