Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates #29

Merged
merged 8 commits into from
Apr 2, 2021
Merged

Minor updates #29

merged 8 commits into from
Apr 2, 2021

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Nov 23, 2020 •
edited
Loading

Some minor updates to the files and the pages.

Visual/UX changes

  • Add citing header on index (About) page (45d930b).
  • Add extra documentation link (in bold) pointing to Swagger/OpenAPI using v1.0.0 of the specification (4d86df4).
  • Add a header to the Documentation page (4d86df4).
  • Logo links to index (About) page (1a5b41c).
  • All external links (in MarkDown files) has the target attribute set to "_blank", opening them in a new tab (295dcb8).

Development changes

  • One sentence per line philosophy implemented for the index (About) page (45d930b).
  • Use HTTPS for the link to the webpage in the README, and fix some MarkDown syntax/linting (de1cbf8).

ml-evs
ml-evs approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM. Cheers @CasperWA.

@CasperWA
Copy link
Member Author

Tested locally and LGTM.

Cheers!
I've just added a final thing: Making sure all external links open in a new tag (at least the ones defined in the MarkDown pages).
I have nothing more for this PR, and only need the "go-ahead" from @gmrigna, as the main "maintainer" of this site.

@CasperWA CasperWA mentioned this pull request Nov 24, 2020
Merged
CasperWA added 2 commits March 31, 2021 13:30
@CasperWA
One sentence per line philosophy
6560b8c 
Put citing information under a separate header.
@CasperWA
Explicitly add v1.0.0 Swagger/OpenAPI
1ee6c1a 
Added in bold to Documentation.
A header is also added to the Documentation page.
@CasperWA CasperWA mentioned this pull request Mar 31, 2021
Merged
8 tasks
@CasperWA
Copy link
Member Author

Updated this with the new changes. Please re-review.

@CasperWA CasperWA requested a review from ml-evs March 31, 2021 15:08
ml-evs
ml-evs reviewed Mar 31, 2021
View reviewed changes
@ml-evs
Copy link
Member

ml-evs commented Apr 2, 2021

Merging on behalf of @CasperWA, thanks again!

@ml-evs ml-evs merged commit c162e2b into Materials-Consortia:master Apr 2, 2021
@CasperWA CasperWA deleted the minor_updates branch April 9, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@gmrigna gmrigna gmrigna approved these changes

@rartino rartino Awaiting requested review from rartino rartino is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CasperWA @ml-evs @gmrigna