Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give warning instead of error for wrong mongo URI #2198

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Conversation

JPBergsma
Copy link
Contributor

@JPBergsma JPBergsma commented Dec 12, 2024

Quick fix for issue #2197 By raising a warning instead of an error optimade should still work even when env vars are used,
and always taking the mongo_database value from the Uri.

I leave it up to @ml-evs to make a more permanent solution.

Quick fix for issue #2197 By raising a warning instead of an error optimade should still work. I leave it up to @ml-evs to make a more permanent solution.
change formatting
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.69%. Comparing base (9af05bc) to head (ba5a9ad).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2198      +/-   ##
==========================================
+ Coverage   90.65%   90.69%   +0.04%     
==========================================
  Files          75       75              
  Lines        4858     4858              
==========================================
+ Hits         4404     4406       +2     
+ Misses        454      452       -2     
Flag Coverage Δ
project 90.69% <100.00%> (+0.04%) ⬆️
validator 90.69% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPBergsma JPBergsma changed the title Update config.py Give warning instead of error for wrong mongo URI Dec 12, 2024
@JPBergsma JPBergsma merged commit dde30a2 into main Dec 13, 2024
13 checks passed
@JPBergsma JPBergsma deleted the JPBergsma-fix_#2197 branch December 13, 2024 08:56
@ml-evs
Copy link
Member

ml-evs commented Dec 16, 2024

Thanks for this @JPBergsma!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants