Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure any relationships or links are ingested when consuming JSONL #2212

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Jan 14, 2025

Previously JSONL ingestions would not look for these keys when inserting into a db, but they should.

@ml-evs ml-evs requested a review from CasperWA as a code owner January 14, 2025 12:03
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.66%. Comparing base (f71a1fb) to head (cfc3e7a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
optimade/utils.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
- Coverage   90.69%   90.66%   -0.04%     
==========================================
  Files          75       75              
  Lines        4858     4862       +4     
==========================================
+ Hits         4406     4408       +2     
- Misses        452      454       +2     
Flag Coverage Δ
project 90.66% <50.00%> (-0.04%) ⬇️
validator 90.66% <50.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs merged commit f2a1d50 into main Jan 14, 2025
12 of 13 checks passed
@ml-evs ml-evs deleted the ml-evs/jsonl-relationships-links branch January 14, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant