Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overly strict validation of disordered structures #2222

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Feb 4, 2025

Closes #2221

@ml-evs ml-evs requested a review from CasperWA as a code owner February 4, 2025 12:03
@ml-evs ml-evs force-pushed the ml-evs/fix-disorder-validation branch from 3925abc to 47386b7 Compare February 4, 2025 12:05
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (1aa540e) to head (47386b7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2222      +/-   ##
==========================================
+ Coverage   90.60%   90.61%   +0.01%     
==========================================
  Files          75       75              
  Lines        4862     4860       -2     
==========================================
- Hits         4405     4404       -1     
+ Misses        457      456       -1     
Flag Coverage Δ
project 90.61% <ø> (+0.01%) ⬆️
validator 90.61% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs merged commit 19ab866 into main Feb 4, 2025
13 checks passed
@ml-evs ml-evs deleted the ml-evs/fix-disorder-validation branch February 4, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overzealous validation of disordered structures
1 participant