Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option exit_after_insert to exit API after inserting data #2223

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Feb 7, 2025

This allows for the standardized ingestion procedure to occur in parallel to a running API, with zero downtime.

@ml-evs ml-evs requested a review from CasperWA as a code owner February 7, 2025 14:40
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.54%. Comparing base (19ab866) to head (049a914).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
optimade/server/main.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2223      +/-   ##
==========================================
- Coverage   90.59%   90.54%   -0.06%     
==========================================
  Files          75       75              
  Lines        4860     4865       +5     
==========================================
+ Hits         4403     4405       +2     
- Misses        457      460       +3     
Flag Coverage Δ
project 90.54% <50.00%> (-0.06%) ⬇️
validator 90.54% <50.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs merged commit a4186a6 into main Feb 7, 2025
10 checks passed
@ml-evs ml-evs deleted the ml-evs/insert-only branch February 7, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant