Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable license and available_licenses info fields #2224

Merged
merged 7 commits into from
Feb 7, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Feb 7, 2025

Closes #1254. Duplicate of #1423 which has to be remerged due to a failed release.

To-do:

  • Add to models
  • Add to OpenAPI
  • Add to config and server response
  • Testing
  • Documentation

@ml-evs ml-evs requested a review from CasperWA as a code owner February 7, 2025 18:27
@ml-evs ml-evs added models For issues related to the pydantic models directly OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 labels Feb 7, 2025
@ml-evs ml-evs force-pushed the ml-evs/license_support branch from 1ac422b to 07b9d81 Compare February 7, 2025 20:41
@ml-evs ml-evs merged commit 2affb50 into main Feb 7, 2025
10 checks passed
@ml-evs ml-evs deleted the ml-evs/license_support branch February 7, 2025 20:42
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.54%. Comparing base (9fb6d3d) to head (07b9d81).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
optimade/server/config.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2224      +/-   ##
==========================================
- Coverage   90.54%   90.54%   -0.01%     
==========================================
  Files          75       75              
  Lines        4865     4885      +20     
==========================================
+ Hits         4405     4423      +18     
- Misses        460      462       +2     
Flag Coverage Δ
project 90.54% <91.30%> (-0.01%) ⬇️
validator 90.54% <91.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models For issues related to the pydantic models directly OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for specifying database licenses
1 participant