Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for space_group_symmetry_operations_xyz #2236

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Feb 28, 2025

As above. Adds the OPTIMADE 1.2 field space_group_symmetry_operations_xyz, superseding #1422.

@ml-evs ml-evs requested a review from CasperWA as a code owner February 28, 2025 12:35
@ml-evs ml-evs added schema Concerns the schema models OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 labels Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (e171370) to head (e86fcd4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
optimade/models/structures.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2236      +/-   ##
==========================================
+ Coverage   90.57%   90.58%   +0.01%     
==========================================
  Files          75       75              
  Lines        4889     4899      +10     
==========================================
+ Hits         4428     4438      +10     
  Misses        461      461              
Flag Coverage Δ
project 90.58% <90.90%> (+0.01%) ⬆️
validator 90.58% <90.90%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs merged commit 2f6050f into main Feb 28, 2025
13 checks passed
@ml-evs ml-evs deleted the ml-evs/symops branch February 28, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 schema Concerns the schema models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant