Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for request_delay in client and server #2237

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Feb 28, 2025

Supersedes #1420 and closes #1247 and closes #1418.

@ml-evs ml-evs marked this pull request as ready for review February 28, 2025 15:25
@ml-evs ml-evs requested a review from CasperWA as a code owner February 28, 2025 15:25
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.58%. Comparing base (6e9d171) to head (f8a35ec).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
optimade/client/client.py 80.00% 2 Missing ⚠️
optimade/server/config.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2237      +/-   ##
==========================================
- Coverage   90.58%   90.58%   -0.01%     
==========================================
  Files          75       75              
  Lines        4899     4917      +18     
==========================================
+ Hits         4438     4454      +16     
- Misses        461      463       +2     
Flag Coverage Δ
project 90.58% <86.36%> (-0.01%) ⬇️
validator 90.58% <86.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs merged commit a03d3cc into main Feb 28, 2025
13 checks passed
@ml-evs ml-evs deleted the ml-evs/add-request-delay branch February 28, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new meta->request_delay field Support request_delay meta value in client
1 participant