Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining symmetry group fields (Hall, HM symbols, IT number) #2240

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 3, 2025

Finishes the remaining work migrating #1422.

@ml-evs ml-evs requested a review from CasperWA as a code owner March 3, 2025 20:16
@ml-evs ml-evs force-pushed the ml-evs/symmetry branch from c82b164 to 7230e65 Compare March 3, 2025 21:05
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (56450cb) to head (7230e65).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2240      +/-   ##
==========================================
+ Coverage   90.58%   90.60%   +0.02%     
==========================================
  Files          75       75              
  Lines        4917     4929      +12     
==========================================
+ Hits         4454     4466      +12     
  Misses        463      463              
Flag Coverage Δ
project 90.60% <100.00%> (+0.02%) ⬆️
validator 90.60% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ml-evs ml-evs merged commit b6c99b9 into main Mar 3, 2025
13 checks passed
@ml-evs ml-evs deleted the ml-evs/symmetry branch March 3, 2025 22:16
@ml-evs ml-evs added schema Concerns the schema models OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 schema Concerns the schema models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant