Use 1.2 grammar by default and relax rules on nested fields #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
ml-evs
force-pushed
the
ml-evs/v1.2-grammar
branch
from
b8226f9 to
51336b6
Compare
|
pre-commit.ci autofix |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
=======================================
Coverage 90.60% 90.61%
=======================================
Files 75 75
Lines 4929 4931 +2
=======================================
+ Hits 4466 4468 +2
Misses 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ml-evs
force-pushed
the
ml-evs/v1.2-grammar
branch
from
4f11c24 to
389353a
Compare
|
pre-commit.ci autofix |
ml-evs
force-pushed
the
ml-evs/v1.2-grammar
branch
from
325d059 to
f35da27
Compare
Bump number of test properties Add skip for elasticsearch test
ml-evs
force-pushed
the
ml-evs/v1.2-grammar
branch
from
000d7a2 to
f1b0731
Compare
ml-evs
added
grammar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply removes the "develop" tag from the v1.2.0 grammar, which should make it the default.
It also allows nested field names to have more flexibility, inspired by e.g., the MP field
_mp_stability.gga_gga+u_r2scan(#2182). The spec reads that dictionary keys must only be strings, not identifiers, so I have relaxed our previous approach of enforcing an identifier to allow for filtering on such fields. I'll do a bit of testing to make sure that this is still URL-safe, but I think we should be fine.